From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97E573081B5 for ; Fri, 7 Nov 2025 10:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512886; cv=none; b=fO9iuRS7f1gU8Inj/DpD0MMmm+eX7ndPj+O4skyH1em21wecRhuvCKH5zGiV8+U+WahtBZi4dFbYNUsNT3iLsezF54BEKr8XpOqQPAC8geGE2cOM94sDnd6IAYMBWYFmykBB/3Wptnkl5cc7WnpLO6A3xWMLwSaUE+JpgxPtsc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762512886; c=relaxed/simple; bh=GbYCIblRZKH7/U4QkVZcpYd2o4yIEdeSQYJGqNKsE6A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FOKzXs4bfOH37ZdeXHTIf8suOwUZ50CI6a7202FT/4nYxS/30yFxzhpW2zz1Nbag8tgrWdzOtEhb0dMtznQDMjc4LY/41bnT4VQ64j8AQGORTVl63XwYyU1KoGMJQO2vpyjsZjW44OwNqZnVN2SNW3X7F3qTJqGlged9rjbc33I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D3ciq7sL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Lgi612pc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D3ciq7sL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lgi612pc" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5A744mVQ2085454 for ; Fri, 7 Nov 2025 10:54:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t3IKVzBz5JQK8wTUX7NukAcRSdlW+wFpDRAPikZl4+E=; b=D3ciq7sL0T/1mqDA KQOUvXh3Mhxuk859eyTuTtyDlTSts27cCw5jo0Qy/Kqfi0+9EEgGjO78tdJgcjiI /ZYPn7i8YLL/cNB3YOhXlcFlNRonkS1KARKEuwJrURUm79wZUJENvHCzLGPw3vJc sS2fL7+89HTzvn+w8+6DMz910/EXVZ1KhlcmAk6+G8RfEVGfOiJfWEu9s2rqXdfY npR/UpgRmaHsmNeiItvcsNJ4uFfteDzCHsTZdCMFaDW+0I45vW7sXMrAK0mQkULJ PcBbv6BEOI8XYuVJ4nEOxTArWjAXQf/S/5TbwBToT9e+cq273Msh3ToXZlizm4UK z0AxXw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a99e795d0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Nov 2025 10:54:43 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8adc67e5340so21687685a.2 for ; Fri, 07 Nov 2025 02:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762512883; x=1763117683; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t3IKVzBz5JQK8wTUX7NukAcRSdlW+wFpDRAPikZl4+E=; b=Lgi612pc3ZQn65enEljcUKaU18LEWIDbueff+LXplpkShu1aqx06Hs7mfsrY9Zo/IN mRWpBK4ROQq+xPoHQp8EiclpnX4ifG+kX9VMphNwDl7iDIoYXYlDVogCp7yIwhFkCaXA sJzZF69UNTPCuQ1GgsWAQP6CrsfsnXLKVJbtZZ/t62YgyKFHjZlB4aya38rxM/gOar32 C/+uJtX7OzR9/n1OQSP5/98zi7swNsXoZOmfXj0wcu4ensmUyXeFc1sDYDkwrBfXuXu/ 2EEpidttHYaaKpiBtopcE5MMNxNfto5g42bQOYHIyEYvIzw3nyOz+K30Y0e9izpNxb4q 7/3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762512883; x=1763117683; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t3IKVzBz5JQK8wTUX7NukAcRSdlW+wFpDRAPikZl4+E=; b=Kgma7FcVgzVrrvRXDJzHcTPbBXVLpMGZ/7bg6txWgmzhrtrH4Vpdq+/NftY8RzemWZ Tsxboc8//x7kKqAexPcCliNFZq1hE41rj8tGnfy12XdC6NVw/e0mvLYoXuTAArOmSBCP qcsLlw2uYWn4rwbVz1R/nrD703g+NRJUr8UUKJ+qwKoizsXGvYd3Madnkgy/vgell4OD 2X9whZagmK3CAjF+BtCZm1IY12oxze7QRRwKFB/o/qTkctas9rnuCNULDyjh+8LcUr0f NA58a0bgbi69dHByzVycjDnBdCzkYVpzu9H7GoXYw0V5XhBv8F9N9G+NHfD1uegUTfXw 1srw== X-Gm-Message-State: AOJu0Yx6R1MulLB5hHJuECQ1fWj3HVy4/8v9jIrxR8dY0gVm/9nb69CU 9nFYIds70ejrGhkP8b/I4bnu/JqImVnyWjlrC8vECZINW6htxeDOSG9ALNPWurV+gBc5vwB5GrM SmKQnZNSpi6EWQ01ApMunGtW1mDdv5fDlg6G3QCeew6X3aqGlQrXells27VlANvLNVKLG X-Gm-Gg: ASbGncuSausZeH8viYdz1jPGBsZWJ3IqiRiYCXYIj8bIDhmxPrwhoz7jtfDBO/Pfc7w 5CImRnK4BP6g66uMbGLEvO7Zs/RdfDnLwbMFnogWORHf9QWcAd67SXRIbnNhl/C0AmDPsXseXYt RXUmwx/DsSApl26Yn3jn5FxqvsAQqvpiufpzoSkcrMyxsVd/0OjNJzjd28LqgKGwviRoCRQ9rsa 6MCujuPliTcfO/QzDCEL+SGUrCAGr4pNO35F6ltS0xvMlvOFwmEY/Zvv/DfDVrFdnDleLiKk2M6 IfHLDzGZ0KxLCWy9+7fd/Zg8mCcyrCjK8FLOfJ74SltnmjlbarKs7vqUwbKQKnJ7g4WxDSBfxgq 66xZZ8HXYY/ehJHJfVSX1/KGjCE3fdogrw6eGE87H/CDY9IrAlJ4QGipI X-Received: by 2002:a05:620a:2a08:b0:8a2:a5b2:e3bf with SMTP id af79cd13be357-8b245297214mr216407885a.6.1762512882724; Fri, 07 Nov 2025 02:54:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IFi7mPq0na085cioUOvqXq74YCfsRc6NxnJgSblNj9scHFLGnEvxVACu852vb4CayQn6idLew== X-Received: by 2002:a05:620a:2a08:b0:8a2:a5b2:e3bf with SMTP id af79cd13be357-8b245297214mr216399685a.6.1762512882057; Fri, 07 Nov 2025 02:54:42 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bfa11367sm205508166b.68.2025.11.07.02.54.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Nov 2025 02:54:41 -0800 (PST) Message-ID: <86df9697-af58-4486-93de-b01df5ba13a6@oss.qualcomm.com> Date: Fri, 7 Nov 2025 11:54:33 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/8] net: stmmac: qcom-ethqos: wrap emac driver data in additional structure To: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Jose Abreu , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Matthew Gerlach , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Keguang Zhang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Lad Prabhakar , Heiko Stuebner , Chen Wang , Inochi Amaoto , Emil Renner Berthing , Minda Chen , Drew Fustini , Guo Ren , Fu Wei , Nobuhiro Iwamatsu , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Shuang Liang , Zhi Li , Shangjuan Wei , "G. Jaya Kumaran" , Clark Wang , Linux Team , Frank Li , David Wu , Samin Guo , Christophe Roullier , Swathi K S Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski References: <20251107-qcom-sa8255p-emac-v5-0-01d3e3aaf388@linaro.org> <20251107-qcom-sa8255p-emac-v5-4-01d3e3aaf388@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251107-qcom-sa8255p-emac-v5-4-01d3e3aaf388@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTA3MDA4OCBTYWx0ZWRfX95LKVuv9Yvn1 27vQmlveaUlfDSjLj33gvIW3ogN7t4wCM9QB/s8NFUZlDyLHloYFKnjlVlCOMNt8c4zntOyss8V j+6/QEVMy31dcSuOyduejWgIaAJk/S1WLlwTjQKyyIRXspvjjlA33LCfNtbR0tu5ZtE6mPAWmLy KTqI8n3DkqJ5SaVmHHcKaf9o3uuE8F62HQyplz6AiVTJX8OEbxiyNersTdq2i/wOV1NYiywOwv0 dP1WnjkNXJhznRMnWM6DI1mM01xb8ytrlHxRNVWyCLUh8SJ5KmcAinaP59CuvotoFKKnKJqx/+w 7JkRNwGr3G09OCyyKCQjFBOBcL1Dm2b+h2tE42uMFZipAywWm6Erb8b8SNJpPq3mUifsU4wk+WR s8BQLTjP47EWlMWlVfbpzh0icg4vow== X-Proofpoint-ORIG-GUID: nWwSgjocP3SjJjDKUjP2gD8ewnKg1WF3 X-Authority-Analysis: v=2.4 cv=A+hh/qWG c=1 sm=1 tr=0 ts=690dcff3 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=4r4FsD-561SDv7fJwu0A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: nWwSgjocP3SjJjDKUjP2gD8ewnKg1WF3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-07_02,2025-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511070088 On 11/7/25 11:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > As the first step in enabling power domain support in the driver, we'll > split the device match data and runtime data structures into their > general and power-management-specific parts. To allow that: first wrap > the emac driver data in another layer which will later be expanded. > > Signed-off-by: Bartosz Golaszewski > --- [...] > static int qcom_ethqos_probe(struct platform_device *pdev) > { > - const struct ethqos_emac_driver_data *data; > + const struct ethqos_emac_driver_data *drv_data; > + const struct ethqos_emac_match_data *data;> struct plat_stmmacenet_data *plat_dat; > struct stmmac_resources stmmac_res; > struct device *dev = &pdev->dev; > @@ -801,13 +822,15 @@ static int qcom_ethqos_probe(struct platform_device *pdev) > ethqos->mac_base = stmmac_res.addr; > > data = device_get_match_data(dev); This change could be made much smaller if you kept a drv_data pointer named 'data' and called the new one match_data but I don't really care either way Reviewed-by: Konrad Dybcio Konrad