From: Takashi Iwai <tiwai@suse.de>
To: Joris Verhaegen <verhaegen@google.com>
Cc: Vinod Koul <vkoul@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Srinivas Kandagatla <srini@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
kernel-team@android.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
linux-arm-msm@vger.kernel.org,
sound-open-firmware@alsa-project.org,
linux-arm-kernel@lists.infradead.org, David Li <dvdli@google.com>,
Miller Liang <millerliang@google.com>
Subject: Re: [PATCH v2 2/4] ALSA: compress_offload: Add SNDRV_COMPRESS_TSTAMP64 ioctl
Date: Fri, 11 Jul 2025 14:45:26 +0200 [thread overview]
Message-ID: <871pqmhp5l.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250711093636.28204-3-verhaegen@google.com>
On Fri, 11 Jul 2025 11:36:28 +0200,
Joris Verhaegen wrote:
> @@ -1355,7 +1389,9 @@ static long snd_compr_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
>
> switch (_IOC_NR(cmd)) {
> case _IOC_NR(SNDRV_COMPRESS_TSTAMP):
> - return snd_compr_tstamp(stream, arg);
> + return snd_compr_tstamp32(stream, arg);
> + case _IOC_NR(SNDRV_COMPRESS_TSTAMP64):
> + return snd_compr_tstamp64(stream, arg);
> case _IOC_NR(SNDRV_COMPRESS_AVAIL):
> return snd_compr_ioctl_avail(stream, arg);
> case _IOC_NR(SNDRV_COMPRESS_PAUSE):
This function was recently updated to evaluate the ioctl cmd value as
is, as found in commit 19c4096ccdd809c6213e2e62b0d4f57c880138cd
ALSA: compress_offload: tighten ioctl command number checks
in sound git tree (likely included in 6.16-rc7).
Please adjust your patch accordingly.
thanks,
Takashi
next prev parent reply other threads:[~2025-07-11 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 9:36 [PATCH v2 0/4] ALSA: compress_offload: Add 64-bit safe timestamp API Joris Verhaegen
2025-07-11 9:36 ` [PATCH v2 1/4] ALSA: compress_offload: Add 64-bit safe timestamp infrastructure Joris Verhaegen
2025-07-11 9:36 ` [PATCH v2 2/4] ALSA: compress_offload: Add SNDRV_COMPRESS_TSTAMP64 ioctl Joris Verhaegen
2025-07-11 12:45 ` Takashi Iwai [this message]
2025-07-11 9:36 ` [PATCH v2 3/4] ALSA: compress_offload: Add SNDRV_COMPRESS_AVAIL64 ioctl Joris Verhaegen
2025-07-11 9:36 ` [PATCH v2 4/4] ASoC: codecs: Implement 64-bit pointer operation Joris Verhaegen
2025-07-11 10:10 ` Richard Fitzgerald
2025-07-15 13:07 ` kernel test robot
2025-07-11 11:56 ` [PATCH v2 0/4] ALSA: compress_offload: Add 64-bit safe timestamp API Charles Keepax
2025-07-11 12:41 ` Takashi Iwai
2025-07-11 13:00 ` Takashi Iwai
2025-07-15 12:39 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pqmhp5l.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=daniel.baluta@nxp.com \
--cc=david.rhodes@cirrus.com \
--cc=dvdli@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel-team@android.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=millerliang@google.com \
--cc=orsonzhai@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=verhaegen@google.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).