From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [patch v2] drm/msm/dsi: free first element on error Date: Thu, 16 Feb 2017 14:27:08 +0200 Message-ID: <871suynwwz.fsf@intel.com> References: <87a89mnznw.fsf@intel.com> <20170216120028.GA29698@mwanda> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mga06.intel.com ([134.134.136.31]:31167 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754149AbdBPM1N (ORCPT ); Thu, 16 Feb 2017 07:27:13 -0500 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rob Clark , Dan Carpenter Cc: Archit Taneja , David Airlie , Hai Li , Rob Herring , Wei Yongjun , linux-arm-msm , "dri-devel@lists.freedesktop.org" , freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org On Thu, 16 Feb 2017, Rob Clark wrote: > On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter wrote: >> We're off by one here. We free something that wasn't allocated and we >> don't free msm_host->bus_clks[]. >> >> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") >> Signed-off-by: Dan Carpenter > > Thanks > > Reviewed-by: Rob Clark And for good measure, Reviewed-by: Jani Nikula > >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c >> index 1fc07ce24686..4fa32296162e 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >> @@ -437,7 +437,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host) >> >> return 0; >> err: >> - for (; i > 0; i--) >> + while (i--) >> clk_disable_unprepare(msm_host->bus_clks[i]); >> >> return ret; -- Jani Nikula, Intel Open Source Technology Center