From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4DE0C4332F for ; Wed, 2 Nov 2022 09:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231218AbiKBJHo (ORCPT ); Wed, 2 Nov 2022 05:07:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231251AbiKBJHD (ORCPT ); Wed, 2 Nov 2022 05:07:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 083CB2870D for ; Wed, 2 Nov 2022 02:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667379843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XBlp2DOijU5hXQ9AriUwp9vEVLgfxcCQxHX+sSZSvOs=; b=cU6CaU/T3cRlN3WmIu3UEc7d6/fczr3AsteLEeSis2kQhSs1jBTSH6BOdcbi98+L1CS4Ff dKMMJcQ9Qorjv5Px2oNHPiQBogLkzL3IpXhZQ2qdQ7DSS4cLXg+T1b+/c8PHb2DjBMo67F JpmKjCMX4nYr+UYWvXcW7BFgqEGjVdg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-583-iMcpoKWaPyO0DEcKOPYAFQ-1; Wed, 02 Nov 2022 05:04:01 -0400 X-MC-Unique: iMcpoKWaPyO0DEcKOPYAFQ-1 Received: by mail-wr1-f70.google.com with SMTP id w23-20020adf8bd7000000b002358f733307so4605848wra.17 for ; Wed, 02 Nov 2022 02:04:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XBlp2DOijU5hXQ9AriUwp9vEVLgfxcCQxHX+sSZSvOs=; b=w4B0kQsWO+CJ51QZ5srGa/o5OWzbtSfSXIOJgd07atoyhRJ1BPhuZ74p6aGjekmd3S NeHZuoj7bEubTceX/R3unsVX+swVa/vR026wURtuE9e4hhVbQvFvlogmVXKqcRbZ1Dkq UMHL96lrqezn+VBScg0uTW4Z9Zg3wuJYkwVuVB+T7JZrCN1YjeQPSaQgrZvE/syxBn15 TDTSYfc4C28L2lqop4KREihKs5TYqJcJyKmM0uNOaXia3TPF5E/jqLt6ZLIa7F0mIahp YKoC5eAJntTiiKPWkeAbq9INWLui1DWcuWCMWOEhMwK9Uz2j0tyIlDOoW8xTS4h8qvUJ X2Og== X-Gm-Message-State: ACrzQf1hZJjsEU2PCp5qZl0YcUpLY409gHxlUeGijKtG4dn4B0SeqbAk KUCVq0QM5cAsNdVTwggp0066MwnhYoh9Dfv5yCEXhru430xP/lX9rwFXWRyPeaNLPf9r3tORlj+ xpwslSjqLZuNyyADYZvfQXpFwnw== X-Received: by 2002:a7b:c409:0:b0:3cf:4c81:8936 with SMTP id k9-20020a7bc409000000b003cf4c818936mr24380799wmi.38.1667379840251; Wed, 02 Nov 2022 02:04:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM72ckpdUoZR+NwXtu1sv2+7NmgS+YMIWWHB7QdeKnWTKduGDRl7tg4bkpenTZv0mX1kFf34kw== X-Received: by 2002:a7b:c409:0:b0:3cf:4c81:8936 with SMTP id k9-20020a7bc409000000b003cf4c818936mr24380784wmi.38.1667379840046; Wed, 02 Nov 2022 02:04:00 -0700 (PDT) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id b13-20020a5d550d000000b002366b17ca8bsm14083933wrv.108.2022.11.02.02.03.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 02:03:59 -0700 (PDT) Message-ID: <87284e5e-859e-3b1c-7142-28d4fa7a7939@redhat.com> Date: Wed, 2 Nov 2022 10:03:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 15/21] drm/fb-helper: Disconnect damage worker from update logic Content-Language: en-US To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, sam@ravnborg.org, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org References: <20221024111953.24307-1-tzimmermann@suse.de> <20221024111953.24307-16-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221024111953.24307-16-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 10/24/22 13:19, Thomas Zimmermann wrote: > The fbdev helpers implement a damage worker that forwards fbdev > updates to the DRM driver. The worker's update logic depends on > the generic fbdev emulation. Separate the two via function pointer. > > The generic fbdev emulation sets struct drm_fb_helper_funcs.fb_dirty, > a new callback that hides the update logic from the damage worker. > It's not possible to use the generic logic with other fbdev emulation, > because it contains additional code for the shadow buffering that > the generic emulation employs. > > DRM drivers with internal fbdev emulation can set fb_dirty to their > own implementation if they require damage handling; although no such > drivers currently exist. > > Signed-off-by: Thomas Zimmermann > --- [...] > static void drm_fb_helper_damage_work(struct work_struct *work) > { > - struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, > - damage_work); > - struct drm_device *dev = helper->dev; > + struct drm_fb_helper *helper = container_of(work, struct drm_fb_helper, damage_work); This line is an unrelated code style change. But I guess it's OK. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat