From: tlinder@codeaurora.org
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Tatyana Brokhman <tlinder@codeaurora.org>,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] usb: usb3.0 ch9 definitions
Date: Sun, 10 Oct 2010 02:49:28 -0700 (PDT) [thread overview]
Message-ID: <874c7b4e0f4fcbc99d074b23595454e5.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <20101010081012.GB18531@linux.intel.com>
Hi Matthew
Page 10-57 you're referring to defines the SuperSpeed USB Device
Capability descriptor for Hub Class. The descriptor itself is defined in
ch9 section 9.6.2.2 and the wReserved is not defined there. Thus the total
length of the descriptor is 10 bytes and not 12.
IMO we should follow the definition in ch9. It seems that ch 10 has a typo
in it. You're right about the errata. I found no reference to this issue
either.
I'll contact USB-IF regarding this issue.
Thanks for bringing this up!
Best regards
Tanya Brokhman
> On Sat, Oct 09, 2010 at 04:46:12PM +0200, Tatyana Brokhman wrote:
>> +/*
>> + * SuperSpeed USB Capability descriptor: Defines the set of SuperSpeed
>> USB
>> + * specific device level capabilities
>> + */
>> +#define USB_SS_CAP_TYPE 3
>> +struct usb_ss_cap_descriptor { /* Link Power Management */
>> + __u8 bLength;
>> + __u8 bDescriptorType;
>> + __u8 bDevCapabilityType;
>> + __u8 bmAttributes;
>> +#define USB_LTM_SUPPORT (1 << 1) /* supports LTM */
>> + __le16 wSpeedSupported;
>> +#define USB_LOW_SPEED_OPERATION (1) /* Low speed operation */
>> +#define USB_FULL_SPEED_OPERATION (1 << 1) /* Full speed operation */
>> +#define USB_HIGH_SPEED_OPERATION (1 << 2) /* High speed operation */
>> +#define USB_5GBPS_OPERATION (1 << 3) /* Operation at 5Gbps */
>> + __u8 bFunctionalitySupport;
>> + __u8 bU1devExitLat;
>> + __le16 bU2DevExitLat;
>> +} __attribute__((packed));
>> +
>> +#define USB_DT_USB_SS_CAP_SIZE 10
>
> Hang on, if we're looking at page 10-57 of "USB 3 0 (11132008)-final.pdf",
> it's 12 bytes long with the last two bytes being wReserved. Is there
> an erratum that changes this? I just looked through
> "USB3_Errata [June 2010].pdf" and don't see any errata that look germane.
>
>
next prev parent reply other threads:[~2010-10-10 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 14:46 [PATCH v5] usb: usb3.0 ch9 definitions Tatyana Brokhman
2010-10-10 8:10 ` Matthew Wilcox
2010-10-10 9:49 ` tlinder [this message]
2010-10-20 6:48 ` tlinder
2010-10-10 10:32 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874c7b4e0f4fcbc99d074b23595454e5.squirrel@www.codeaurora.org \
--to=tlinder@codeaurora.org \
--cc=gregkh@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).