From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B7AC433DB for ; Sun, 31 Jan 2021 15:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 741CF64E4F for ; Sun, 31 Jan 2021 15:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231204AbhAaOdg (ORCPT ); Sun, 31 Jan 2021 09:33:36 -0500 Received: from mail29.static.mailgun.info ([104.130.122.29]:24013 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232428AbhAaOTS (ORCPT ); Sun, 31 Jan 2021 09:19:18 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612102730; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=is+Y0S6VYuSq/a22S7AdpwgFKHNWJy9S/ugml5uNJWU=; b=G0TTPRUbJusi7Hxmiw6IH80yele7CAwEc+RbZP3Y1tOTjYbpH4443SJk86WWCHL+hmhXFbN0 3EyuwHk7kYEcstkWOwD2SnOSgn/1LiZTNvyCZXwszwdAlB0Mo4bSg8maHkYr+C8aOvNq4htj +neOEenw0sqeq/AsihIVUvg43JA= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 6016bc2f7a21b36a9deb2f5d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 31 Jan 2021 14:18:23 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D7BDAC433CA; Sun, 31 Jan 2021 14:18:22 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E7039C433C6; Sun, 31 Jan 2021 14:18:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E7039C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , Arnd Bergmann , Greg Kroah-Hartman , Stanimir Varbanov , Lorenzo Pieralisi , Bjorn Helgaas , linux-arm-msm@vger.kernel.org, Manivannan Sadhasivam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2 1/5] misc: qca639x: add support for QCA639x powerup sequence References: <20210128175225.3102958-1-dmitry.baryshkov@linaro.org> <20210128175225.3102958-2-dmitry.baryshkov@linaro.org> Date: Sun, 31 Jan 2021 16:18:16 +0200 In-Reply-To: <20210128175225.3102958-2-dmitry.baryshkov@linaro.org> (Dmitry Baryshkov's message of "Thu, 28 Jan 2021 20:52:21 +0300") Message-ID: <875z3dmbpz.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Dmitry Baryshkov writes: > Qualcomm QCA639x is a family of WiFi + Bluetooth SoCs, with BT part > being controlled through the UART and WiFi being present on PCIe > bus. Both blocks share common power sources. Add device driver handling > power sequencing of QCA6390/1. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/misc/Kconfig | 12 +++ > drivers/misc/Makefile | 1 + > drivers/misc/qcom-qca639x.c | 164 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 177 insertions(+) > create mode 100644 drivers/misc/qcom-qca639x.c > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index e90c2524e46c..a14f67ab476c 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -255,6 +255,18 @@ config QCOM_FASTRPC > applications DSP processor. Say M if you want to enable this > module. > > +config QCOM_QCA639X > + tristate "Qualcomm QCA639x WiFi/Bluetooth module support" > + depends on REGULATOR && PM_GENERIC_DOMAINS > + help > + If you say yes to this option, support will be included for Qualcomm > + QCA639x family of WiFi and Bluetooth SoCs. Note, this driver supports > + only power control for this SoC, you still have to enable individual > + Bluetooth and WiFi drivers. > + > + Say M here if you want to include support for QCA639x chips as a > + module. This will build a module called "qcom-qca639x". Is this is something you need on ARM platforms? As on x86 this is definitely not needed, for example it's enough to load ath11k_pci to get QCA6390 Wi-Fi working. I think the documentation should be clarified where this QCOM_QCA639X is needed (and it's not needed on normal PCI devices). -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches