From: Gokul Krishna Krishnakumar <quic_gokukris@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Trilok Soni <quic_tsoni@quicinc.com>,
Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
"Elliot Berman" <quic_eberman@quicinc.com>,
Guru Das Srinagesh <quic_gurus@quicinc.com>,
Sibi Sankar <quic_sibis@quicinc.com>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 0/1] Add trace events for remoteproc
Date: Mon, 27 Feb 2023 11:54:51 -0800 [thread overview]
Message-ID: <877d045b-59ad-1e77-1527-e1b2a7e3c331@quicinc.com> (raw)
In-Reply-To: <20230227193620.hzrlt3e5vh5xz74v@ripper>
On 2/27/2023 11:36 AM, Bjorn Andersson wrote:
> On Fri, Feb 24, 2023 at 08:51:41AM -0800, Gokul krishna Krishnakumar wrote:
>> This patch attempts to add traces for important remoteproc events,
>> this will help in debugging errors with the subsystem restart and
>> also helps in getting an estimate on how long each event takes to run.
>>
>
> Please skip sending cover-letters for single patches. Also, this is the
> kind of motivation that should be included in the commit message.
>
> Thanks,
> Bjorn
>
Thanks Bjorn, Moving this to the commit text.
>> Gokul krishna Krishnakumar (1):
>> remoteproc: qcom: Add remoteproc tracing
>>
>> drivers/remoteproc/Makefile | 3 ++-
>> drivers/remoteproc/qcom_common.c | 25 +++++++++++++++++++
>> drivers/remoteproc/qcom_q6v5.c | 3 +++
>> drivers/remoteproc/qcom_q6v5_pas.c | 17 +++++++++++++
>> drivers/remoteproc/qcom_sysmon.c | 13 ++++++++++
>> drivers/remoteproc/qcom_tracepoints.c | 10 ++++++++
>> include/trace/events/rproc_qcom.h | 36 +++++++++++++++++++++++++++
>> 7 files changed, 106 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/remoteproc/qcom_tracepoints.c
>> create mode 100644 include/trace/events/rproc_qcom.h
>>
>>
>> base-commit: 7c855ef7137a67bcff0e039691b969428dd8ef6a
>> --
>> 2.39.2
>>
Thanks,
Gokul
prev parent reply other threads:[~2023-02-27 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 16:51 [PATCH v1 0/1] Add trace events for remoteproc Gokul krishna Krishnakumar
2023-02-24 16:51 ` [PATCH v1 1/1] remoteproc: qcom: Add remoteproc tracing Gokul krishna Krishnakumar
2023-02-24 17:08 ` Elliot Berman
2023-02-24 17:17 ` Trilok Soni
2023-02-27 20:06 ` Bjorn Andersson
2023-03-03 3:27 ` Gokul Krishna Krishnakumar
2023-02-27 19:36 ` [PATCH v1 0/1] Add trace events for remoteproc Bjorn Andersson
2023-02-27 19:54 ` Gokul Krishna Krishnakumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d045b-59ad-1e77-1527-e1b2a7e3c331@quicinc.com \
--to=quic_gokukris@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_eberman@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_satyap@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tsoni@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox