From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH 3/3] wcn36xx: Fix WEP encryption Date: Thu, 14 Jun 2018 17:28:56 +0300 Message-ID: <87d0wt8ms7.fsf@kamboji.qca.qualcomm.com> References: <1527506960-13358-1-git-send-email-loic.poulain@linaro.org> <1527506960-13358-3-git-send-email-loic.poulain@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1527506960-13358-3-git-send-email-loic.poulain-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> (Loic Poulain's message of "Mon, 28 May 2018 13:29:20 +0200") Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Loic Poulain Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org Loic Poulain writes: > In case of WEP encryption, driver has to configure shared key for > associated station(s). Note that sta pointer is NULL in case of non > pairwise key, causing NULL pointer dereference with existing code > (sta_priv->is_data_encrypted). Fix this by using associated sta list > instead. > > Signed-off-by: Loic Poulain I guess this fix is for AP mode with WEP encryption? And client mode with WEP doesn't have any issues? If yes, I'll clarify that in the commit log. -- Kalle Valo