From: Jani Nikula <jani.nikula@intel.com>
To: Marc Gonzalez <mgonzalez@freebox.fr>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Arnaud Vrac <avrac@freebox.fr>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
Nathan Chancellor <nathan@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused
Date: Thu, 12 Sep 2024 14:15:17 +0300 [thread overview]
Message-ID: <87ed5pgm2i.fsf@intel.com> (raw)
In-Reply-To: <9028f858-8c6d-4292-a6aa-27eedff3ac8b@freebox.fr>
On Thu, 12 Sep 2024, Marc Gonzalez <mgonzalez@freebox.fr> wrote:
> On 11/09/2024 12:23, Jani Nikula wrote:
>> On Tue, 10 Sep 2024, Marc Gonzalez <mgonzalez@freebox.fr> wrote:
>>> On 10/09/2024 16:51, Dmitry Baryshkov wrote:
>>>> On Tue, Sep 10, 2024 at 01:03:43PM GMT, Jani Nikula wrote:
>>>>> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
>>>>> inline functions for W=1 build").
[snip]
>> GCC doesn't catch unused static inlines, while Clang does.
>
> It makes no sense to me that adding "inline" would prevent
> GCC from diagnosing the issue... GCC should simply ignore
> the "inline" keyword when definition is not in a header file
> (maybe they don't store "origin").
Please just read the commit message for the commit I reference above for
details. There's not much more I could say about it.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-12 11:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1725962479.git.jani.nikula@intel.com>
2024-09-10 10:03 ` [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused Jani Nikula
2024-09-10 14:51 ` Dmitry Baryshkov
2024-09-10 15:54 ` Marc Gonzalez
2024-09-11 10:23 ` Jani Nikula
2024-09-12 10:56 ` Marc Gonzalez
2024-09-12 11:15 ` Jani Nikula [this message]
2024-09-12 12:14 ` Marc Gonzalez
2024-09-12 12:28 ` Dmitry Baryshkov
2024-09-12 12:50 ` Marc Gonzalez
2024-09-12 13:05 ` Dmitry Baryshkov
2024-09-12 13:10 ` Jani Nikula
2024-09-21 21:16 ` Dmitry Baryshkov
2024-09-23 6:38 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed5pgm2i.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=avrac@freebox.fr \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mgonzalez@freebox.fr \
--cc=nathan@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox