From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D725F381AA for ; Mon, 8 Apr 2024 08:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712563787; cv=none; b=Uje4AKw9pxpE1Bdvm+EcFFVrVZ8xoGN4jJpnPE9QjWsu7mH+sfXfys1+CKgzgN1qC/eCA3TKckkHC3JO1ifUHTwQwKZFSglJHAN0/P9IjFdcqxQdtD3zKsQJSer4RHpFoA8ZAyB0sEVik9YxVlicUh5GTMifxXsYv01qdVAdUV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712563787; c=relaxed/simple; bh=92BGp6JXhIHjCCB0FTx9liwfLuaO5IB0b70sT0CrC4M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ToAlFKoPP6Gej5cCVOyY2+k8Ye8CxHQwUwd2ElS9emaa4TGJC7eVk5ez6Q+ilb+Xfccf/yYybKx+FtcDMXAB8n8s1lPXD5LBka0HFR7lSVCzIKq/GG698Zjogk0hx6qpsivsaz8Xef53ZK+YzixJ0xqUxhFOgywF06NN7XpXbEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZfUte0Pr; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZfUte0Pr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712563786; x=1744099786; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=92BGp6JXhIHjCCB0FTx9liwfLuaO5IB0b70sT0CrC4M=; b=ZfUte0PrwjKPvuFu7q2eBZFmBodL+1D7qFs88FDmJe6kgJWQG4KVhNCS Kvux7O6by6H6NzsziCy14MdCGtXhcx/EtuqaO6dJe0eL67Zg8GhIMft2L hC5/Clri6ZQK3Kq/6WomhUFLN2gkWRQmaY/1HJD5Rx3x66wwIbjI1GXog PY3pD18rc5RhhZT3JzZo9atgCIZeoCVzw2GldBvwawwcibvvN6/wM/Vfj GCkAPPrMvt7zQMBoGSjyMW6NHCcvKjT+6pv5fZWDIwPXu69qG7LuOgo9d x4DxLs5vfrdYlwNGXtXaan83unnCnhO9GE19OpQdyOWbIQ8BwThBVr0Bm w==; X-CSE-ConnectionGUID: 4k3ubDlTTd2vvpW7/3x7Sg== X-CSE-MsgGUID: jcbjlHf4RLe+az55g+gcNQ== X-IronPort-AV: E=McAfee;i="6600,9927,11037"; a="25327656" X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="25327656" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 01:09:45 -0700 X-CSE-ConnectionGUID: jpUK233HQLGo48IwE0EMYQ== X-CSE-MsgGUID: ZRyUmMmIQqKJ0iZNBs7QHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="57270073" Received: from bauinger-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.42.71]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 01:09:42 -0700 From: Jani Nikula To: Dmitry Baryshkov Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Aishwarya TCV Subject: Re: [PATCH] drm/msm: convert all pixel format logging to use %p4cc In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240405092907.2334007-1-jani.nikula@intel.com> Date: Mon, 08 Apr 2024 11:09:38 +0300 Message-ID: <87frvwb7i5.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, 05 Apr 2024, Dmitry Baryshkov wrote: > On Fri, Apr 05, 2024 at 12:29:07PM +0300, Jani Nikula wrote: >> Logging u32 pixel formats using %4.4s format string with a pointer to >> the u32 is somewhat questionable, as well as dependent on byte >> order. There's a kernel extension format specifier %p4cc to format 4cc >> codes. Use it across the board in msm for pixel format logging. >> >> This should also fix the reported build warning: >> >> include/drm/drm_print.h:536:35: warning: '%4.4s' directive argument is >> null [-Wformat-overflow=] >> >> Reported-by: Aishwarya TCV >> Closes: https://lore.kernel.org/r/2ac758ce-a196-4e89-a397-488ba31014c4@arm.com >> Signed-off-by: Jani Nikula >> >> --- >> >> Tip: 'git show --color-words -w' might be the easiest way to review. >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +++---- >> .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 2 +- >> drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++-- >> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 24 +++++++++---------- >> drivers/gpu/drm/msm/msm_fb.c | 10 ++++---- >> 5 files changed, 24 insertions(+), 24 deletions(-) > > Reviewed-by: Dmitry Baryshkov Thanks! Do you take this via the msm tree? BR, Jani. -- Jani Nikula, Intel