From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Subject: Re: [PATCH V4 02/26] powerpc/PCI: deprecate pci_get_bus_and_slot() Date: Tue, 19 Dec 2017 21:29:01 +1100 Message-ID: <87fu879fki.fsf@concordia.ellerman.id.au> References: <1513661883-28662-1-git-send-email-okaya@codeaurora.org> <1513661883-28662-3-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1513661883-28662-3-git-send-email-okaya@codeaurora.org> Sender: linux-pci-owner@vger.kernel.org To: linux-pci@vger.kernel.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya , Benjamin Herrenschmidt , Paul Mackerras , Tyrel Datwyler , Rob Herring , Bhumika Goyal , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , open list List-Id: linux-arm-msm@vger.kernel.org Sinan Kaya writes: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function in favor of > pci_get_domain_bus_and_slot(). > > Use pci_get_domain_bus_and_slot() with a domain number of 0 as the code > is not ready to consume multiple domains and existing code used domain > number 0. > > Signed-off-by: Sinan Kaya > --- > arch/powerpc/kernel/pci_32.c | 3 ++- > arch/powerpc/platforms/powermac/feature.c | 2 +- > arch/powerpc/sysdev/mv64x60_pci.c | 4 ++-- > 3 files changed, 5 insertions(+), 4 deletions(-) Looks to do what it says. I don't know if any of these call sites could be improved to provide the domain, but that's not really your problem. Acked-by: Michael Ellerman (powerpc) cheers