From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76295171B8 for ; Mon, 4 Dec 2023 12:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GXUzL6dt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35B42C433CA; Mon, 4 Dec 2023 12:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701694589; bh=k1Fhg2mWlHmV5n1NuNSkIzP6fUr0CnTak9xgAFNRfw0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GXUzL6dtd/FoA8s1miHuIcj/mdyoT3EhC80y4TuZR69lKsiBk9Fx4bIDke5j+2J1a lav1XRRR9DcUGGzaUf3JW/3zQPvzJDhul7aXGoPslyZZB+jQvtED61AxvhPN61zCaO wGDxpmoBOiHNtisG/8lmlxJNmj+qdvoGus3fZqWsdSPW6fJSJJHsiY0ILvUZeHUBWR wa0S3J6YTdmZAVpy4J7JOFLZzO8XPvy6d6zlPGo+YV3Iptha7B+A85+x9y6HbNU0lu OoAffTMBvoh3EU3Vrd6T9sn2gTe7yhQhKCQNaIMvQXpLdAlOzN5YKogBA+crqlmnqS iIUIxOBchIzhQ== From: Kalle Valo To: Dmitry Baryshkov Cc: ath10k@lists.infradead.org, "open list:DRM DRIVER FOR MSM ADRENO GPU" Subject: Re: ath10k / WCN3990: firmware-5.bin and wlanmdsp.mbn being out of sync References: Date: Mon, 04 Dec 2023 14:56:25 +0200 In-Reply-To: (Dmitry Baryshkov's message of "Sat, 25 Nov 2023 05:23:20 +0200") Message-ID: <87leaaqg7a.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi Dmitry, Dmitry Baryshkov writes: > I wanted to ask your opinion regarding one of the issues we stumbled > upon on the Qualcomm RB1 and RB2 platforms. These platforms use ath10k > snoc (WCN3990) WiFi "card". We noticed the following messages being > spawned on the console, which I traced it to the > ATH10K_FW_FEATURE_SINGLE_CHAN_INFO_PER_CHANNEL feature: > > ath10k_snoc c800000.wifi: chan info: invalid frequency 0 (idx 41 out of bounds) > > As a reminder, on this platform the wlan firmware and firmware-N.bin > files come separately. > The wlanmdsp.mbn is downloaded by the onboard modem DSP via the > tqftpserv request (which is served from the board-specific folder > qcom/qcm2210). The firmware-N.bin file is loaded by the WiFi driver > itself from the generic folder, ath10k/WCN3990/hw1.0. Current > firmware-5.bin file was provided with the sdm845's wlanmdsp.mbn, which > is older than qcm2210/qrb4210's wlanmdsp.mbn. > > I'm looking for suggestions on how to make ath10k driver load > firmware-N.bin file which corresponds to the board-specific > wlanmdsp.mbn. We have had similar discussions in the past but it didn't go very far. It would be so nice if you could finally fix this :) At one point we even had a discussion that we might need something similar for ath11k but it didn't go anywhere. > In particular I'd like to hear your opinion on the following proposal: > > Add the optional property to the board DT, that specifies: > firmware-name = "path/to/wlanmdsp.mbn". The property, if present, > will be used as an override for the firmware directory. So, while the > ath10k driver will not load wlanmdsp.mbn on its own, it will still > look for the firmware-N files in the specified directory. Back in the day I was thinking something like below, please let me know what you think. So the normal firmware path for WCN3990 is: ath10k/WCN3990/hw1.0/ My idea was that if we could extend it for different "platforms" (not sure what's the proper term for this) by having platform specific directories: ath10k/WCN3990/hw1.0-platform/ (Replace "platform" with a unique name for the platform, for example "acme-kv7" for a product from Acme with model name kv7.) Then DT could inform ath10k about this "platform" string and ath10k would then download boath firmware-N.bin and board-2.bin from the platform specific directory. And even cleaner if we could have the *.mbn firmware files in the same directory, even if ath10k doesn't access them directly. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches