From: Hans de Goede <johannes.goede@oss.qualcomm.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: monaco: Fix CSI I2C controllers default bus frequency
Date: Thu, 20 Aug 2026 12:11:27 +0200 [thread overview]
Message-ID: <884bb199-e181-41da-b364-9e15cf6b0eaf@oss.qualcomm.com> (raw)
In-Reply-To: <b44872a8-dd59-4f0a-8665-c4f23a6b86bc@linaro.org>
Hi,
On 31-Jul-26 08:41, Vladimir Zapolskiy wrote:
> On 7/24/26 17:22, Hans de Goede wrote:
>> Hi,
>>
>> On 24-Jul-26 1:42 PM, Konrad Dybcio wrote:
>>> On 7/23/26 1:48 PM, Hans de Goede wrote:
>>>> 1 MHz is quite fast for an I2C bus and not necessarly reliable, change this
>>>> to 400 KHz which is a more reasonable default.
>>>>
>>>> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
>>>
>>>
>>> I guess this is a question of what's more common among client
>>> devices. I assume you have some that aren't happy with 1 MHz?
>>
>> Looking at ACPI tables for many x86 devices 400 KHz is the standard,
>> with some devices going down to 100 KHz. 1 MHz is pretty much
>> unheard off.
>>
>> Note the official I2C spec is limited to 100 KHz anything faster then
>> that is an extension.
>>
>> My specific reason for submitting this patch is imx219 sensors on
>> Mona sometimes failing to initialize at 1MHz which is kinda to
>> be expected when going for 10x the I2C specification max value.
>>
>
> 1 MHz I2C bus speed is in the v3 of the I2C specification dated 2007,
> its name is Fast-mode Plus (Fm+), thus the statement above is invalid.
Yes I'm aware of Fast-mode Plus being in the spec, but it is
an *extension* to the original spec.
The only speed which is guaranteed to work everywhere is 100 kHz.
Now a days 400 KHz usually will work, but e.g. the DSDT of
the Samsung Galaxy Go LTE NP345XLA Snapdragon laptop limits one of
the busses to 100 kHz because the TI BQ25710 cannot handle 400 kHz
(its an SMBus device and the SMBus 2.0 spec limits the bus to 100 KHz).
Or since this is about the CSI I2C controllers, picking a random
camera sensor I've a datasheet for here, the ov8110 lists the minimum
data low time as 1.3 ųs, which means it cannot run at 1 MHz either.
I've seen a ton of I2C devices and I2C device descriptions in
ACPI tables of x86_64 and them using 1MHz is something which I've
never seen.
So 1 MHz just is a really poor default independent of the issues
you mention where we end up with a different speed then requested
due to the I2C controller parent clock running at the wrong freq.
Regards,
Hans
next prev parent reply other threads:[~2026-08-20 10:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 11:48 [PATCH] arm64: dts: monaco: Fix CSI I2C controllers default bus frequency Hans de Goede
2026-07-24 11:42 ` Konrad Dybcio
2026-07-24 14:22 ` Hans de Goede
2026-07-24 15:22 ` Konrad Dybcio
2026-07-31 6:41 ` Vladimir Zapolskiy
2026-08-20 10:11 ` Hans de Goede [this message]
2026-07-31 3:24 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=884bb199-e181-41da-b364-9e15cf6b0eaf@oss.qualcomm.com \
--to=johannes.goede@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox