From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DCC7C0015E for ; Wed, 26 Jul 2023 17:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbjGZRw2 (ORCPT ); Wed, 26 Jul 2023 13:52:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbjGZRw1 (ORCPT ); Wed, 26 Jul 2023 13:52:27 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B894E77 for ; Wed, 26 Jul 2023 10:52:25 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-4fb7373dd35so1636715e87.1 for ; Wed, 26 Jul 2023 10:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690393944; x=1690998744; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=YVO58FHteX4EULGG7zXipTSlDy4hu/mSuvZkpOily3k=; b=PUJKuuwbKJfeKRKVxAwkioiHsnhQnMcjDgPXnxMNjttnEDE/+BglDX63I+M+Mx3tzS gBwfZCr0zrRydMqQzWyxc6sZK8LPkkdMSFaZiCohklR02uIV67S1PvjqxdiAiUFzPdMk nVmFQKDgzfEyYjVy6FeSPe3Yw1y1PEvQuRI7uMEv0y8x+5bSVvzaE/S3FZFE17t7oGdP 6O5OIBvujJ72/6ZTYdpm9kvln0Gbv9GvdZGYmBz91olHvOw10WrCBt3eDu5QO4qRFvDN YaLtKEl6I1t8CUbky8a9DZz3Ez9SwnfJ1OFeNphOjwQtxBLJqMhq98iUBVPTXNKNf+am UbIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690393944; x=1690998744; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YVO58FHteX4EULGG7zXipTSlDy4hu/mSuvZkpOily3k=; b=g6GJxkiwywHeHGotfr27J5MHl0/bUNLUAZhAxnG5KlHuWLdkREeVBfuN/RS3ny1brD HOFyBOqMuPmz4FpcQ1oNB5qO63f5d/R94efBpFhFwz/8JvdTYpbkSItM+w7e/hsPL0P3 mzSCUXA/NuSM0/tugPtJnnA0A6xUn9Mnzm1zJw/YheAEERQafHfrh1aplkoKaXBSyyzS ryz3KogFbEcKGlycwjWZtEjeSymHyJpu22tDpd5KIHWRPcyprHR02BiDmFDG8t4UCm2K rRG9Yf4nfNbSvHt1OVkL3ayHOaonfyZpe8k/5dZbjKTeoj88jRLad5IKLbfcmf9fbzkc Qv5A== X-Gm-Message-State: ABy/qLbFgaxjhWsWXjUCVYQgXHcyRTq7JpP+CrhBsKyIna0ZEeZTlm4E 7C3Ov80KOgNM/0qzaF+PtydyXg== X-Google-Smtp-Source: APBJJlF1UQJUHoAPg9+WkjejxrUhgoGYxVfQf96mmywhElB413YJ2401ozJWhPfN+wGMUT1phLJbRQ== X-Received: by 2002:a19:f704:0:b0:4fb:103f:7d56 with SMTP id z4-20020a19f704000000b004fb103f7d56mr74778lfe.14.1690393943803; Wed, 26 Jul 2023 10:52:23 -0700 (PDT) Received: from [192.168.1.101] (abyl5.neoplus.adsl.tpnet.pl. [83.9.31.5]) by smtp.gmail.com with ESMTPSA id q2-20020a19a402000000b004fde41a2059sm2997365lfc.305.2023.07.26.10.52.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 10:52:23 -0700 (PDT) Message-ID: <88658e21-c8eb-47de-9c4d-76a3f645af0e@linaro.org> Date: Wed, 26 Jul 2023 19:52:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] interconnect: qcom: qcm2290: Set AB coefficients Content-Language: en-US From: Konrad Dybcio To: Stephan Gerhold Cc: Andy Gross , Bjorn Andersson , Georgi Djakov , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230726-topic-icc_coeff-v1-0-31616960818c@linaro.org> <20230726-topic-icc_coeff-v1-2-31616960818c@linaro.org> <5667c93a-408f-3802-b168-f3a145dfcb43@linaro.org> <0e5e5343-1831-c922-8f79-93cb9073dee3@linaro.org> Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <0e5e5343-1831-c922-8f79-93cb9073dee3@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 26.07.2023 19:46, Konrad Dybcio wrote: > On 26.07.2023 19:26, Stephan Gerhold wrote: >> On Wed, Jul 26, 2023 at 07:20:27PM +0200, Konrad Dybcio wrote: >>> On 26.07.2023 19:18, Stephan Gerhold wrote: >>>> On Wed, Jul 26, 2023 at 06:25:44PM +0200, Konrad Dybcio wrote: >>>>> Some buses need additional manual adjustments atop the usual >>>>> calculations. Fill in the missing coefficients. >>>>> >>>>> Signed-off-by: Konrad Dybcio >>>> >>>> What about the funny util-fact/vrail-comp on the mas-apps-proc node >>>> downstream? >>> Can't see it neither on msm-5.4 (with the icc API) nor in the 4.19 (msmbus) >>> device tree. >>> >> >> Not sure where to get up-to-date device trees nowadays. The AOSP repo >> I was looking at has this commit where it was added: >> https://android.googlesource.com/kernel/msm-extra/devicetree/+/02f8c342b23c20a5cf967df649814be37a08227c%5E%21/#F0 > Oh right, take a look at this one: > > https://git.codelinaro.org/clo/la/kernel/msm-4.14/-/commit/201df022706e100cef8d28983c6a7b883fcaec5a > > I guess I'll need to update the icc driver then. Moreover, this having vrail-comp = 96, means I'll have to go with the wrecked downstream way of *(100/(percent)) instead of *(percent/100)... I also noticed that sm6125 makes very heavy use of per-node clocks.. Konrad