From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Johan Hovold <johan@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] ASoC: codecs: wcd93xx: fix OF node leaks on probe failure
Date: Mon, 1 Dec 2025 12:18:18 +0000 [thread overview]
Message-ID: <88b63ab9-85bc-4af1-a802-e2e2f332254f@oss.qualcomm.com> (raw)
In-Reply-To: <20251201093419.24474-1-johan@kernel.org>
On 12/1/25 9:34 AM, Johan Hovold wrote:
> The original wcd938x driver has a couple of OF node reference leaks
> which have been reproduced in the two later added drivers.
>
> Johan
>
Thanks for the patches,
Yes, of_parse_phandle() already gets a node refcount, another refcount
is redundant and will leak.
LGTM
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
--srini>
> Johan Hovold (3):
> ASoC: codecs: wcd937x: fix OF node leaks on probe failure
> ASoC: codecs: wcd938x: fix OF node leaks on probe failure
> ASoC: codecs: wcd939x: fix OF node leaks on probe failure
>
> sound/soc/codecs/wcd937x.c | 4 ++--
> sound/soc/codecs/wcd938x.c | 3 +--
> sound/soc/codecs/wcd939x.c | 3 +--
> 3 files changed, 4 insertions(+), 6 deletions(-)
>
next prev parent reply other threads:[~2025-12-01 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 9:34 [PATCH 0/3] ASoC: codecs: wcd93xx: fix OF node leaks on probe failure Johan Hovold
2025-12-01 9:34 ` [PATCH 1/3] ASoC: codecs: wcd937x: " Johan Hovold
2025-12-01 9:34 ` [PATCH 2/3] ASoC: codecs: wcd938x: " Johan Hovold
2025-12-01 9:34 ` [PATCH 3/3] ASoC: codecs: wcd939x: " Johan Hovold
2025-12-01 12:18 ` Srinivas Kandagatla [this message]
2025-12-04 13:04 ` [PATCH 0/3] ASoC: codecs: wcd93xx: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88b63ab9-85bc-4af1-a802-e2e2f332254f@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=johan@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox