From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: claudiu beznea <claudiu.beznea@tuxon.dev>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>, Peng Fan <peng.fan@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Nishanth Menon <nm@ti.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
linux-stm32@st-md-mailman.stormreply.com,
NXP Linux Team <linux-imx@nxp.com>,
linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-omap@vger.kernel.org, linux-media@vger.kernel.org,
linux-phy@lists.infradead.org, alsa-devel@alsa-project.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] clk: constify the of_phandle_args argument of of_clk_provider
Date: Mon, 19 Feb 2024 07:59:36 +0100 [thread overview]
Message-ID: <88de75cd-4069-4be6-9c4e-f32befa46d58@linaro.org> (raw)
In-Reply-To: <e43727bd-d83d-4271-9871-ff995c8e7d03@tuxon.dev>
On 19/02/2024 07:25, claudiu beznea wrote:
>
>
> On 08.02.2024 18:37, Krzysztof Kozlowski wrote:
>> None of the implementations of the get() and get_hw() callbacks of
>> "struct of_clk_provider" modify the contents of received of_phandle_args
>> pointer. They treat it as read-only variable used to find the clock to
>> return. Make obvious that implementations are not supposed to modify
>> the of_phandle_args, by making it a pointer to const.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> drivers/clk/at91/pmc.c | 3 +-
>> drivers/clk/at91/pmc.h | 3 +-
>
> Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
You understand there is no review for "part of patch"? You probably
meant Acked-by.
https://elixir.bootlin.com/linux/v6.8-rc5/source/Documentation/process/submitting-patches.rst#L544
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-19 6:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 16:37 [PATCH] clk: constify the of_phandle_args argument of of_clk_provider Krzysztof Kozlowski
2024-02-12 10:02 ` Charles Keepax
2024-02-15 23:12 ` Stephen Boyd
2024-02-16 7:12 ` Krzysztof Kozlowski
2024-02-19 19:08 ` Stephen Boyd
2024-02-16 11:23 ` Thierry Reding
2024-02-16 11:46 ` Geert Uytterhoeven
2024-02-19 1:03 ` Peng Fan
2024-02-19 6:25 ` claudiu beznea
2024-02-19 6:59 ` Krzysztof Kozlowski [this message]
2024-02-19 7:33 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88de75cd-4069-4be6-9c4e-f32befa46d58@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=konrad.dybcio@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=patches@opensource.cirrus.com \
--cc=peng.fan@nxp.com \
--cc=perex@perex.cz \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=sudeep.holla@arm.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).