From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E04C208C0 for ; Mon, 19 Feb 2024 06:59:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708325984; cv=none; b=fPoeM+BwD8JvNDRYiuarlhR18B7fHXVHj/T6kBEocnEMxxqS1DLXcgt4n/XlUkYLjkz2IMlKlimees7UbEdrhltyd3LbzKeZ/4TPYsnSK5J2cp+YtmIFlsibFr0UtVvXpDXQTg2Futbt0j04/orP0OP9R58oVDbwh7HB+h9ywSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708325984; c=relaxed/simple; bh=O7TNXSeYWhSRDIyTU040+dYsyYLZBzGzE8mC/WyM6es=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=GgZw7YTs47YBcYJUicFv3jzlYTMODhdBq0GRTEuGkRdg3xO/gH5pnzwl07Adj2i3H66vYtlxAvdH1TfeOoTpDqLv+anURH/bfFiu971rpN9dHFq0SrwVQ/eQu7BWlLl4xHcUfP/WIWMScwhon1nIj6sYdpAdYNxcHHD34Ff/Lrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=epFrHBKa; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="epFrHBKa" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4126099ccdeso10764035e9.2 for ; Sun, 18 Feb 2024 22:59:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708325981; x=1708930781; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=AfAV24x7YrRfp7a1aPkTeFhdi55Bp5TvgPp9C25tWp0=; b=epFrHBKaSrvfhLPRoyd9Ko6N+TXpOdZFs0aO8QwAMs1wv/aHNxpJPiz/UbphWkfDhD c6J82iBABjvPxmWQ6JqJ/WUFtua87hee53DS5YARXp5bmKiGC2+TsSbh9/GV8Y1jTqr2 NiDHqz8AYOScx8ajkQ7OXO3ygxejL5rkyPGWZV9jHN6s5ryR3iRbhmHh/0KxMRx1EqZ0 1EbZWsiv+It8KvRazDsXO+7DRIMD7HhTWEVGszVA4GzxaP5aAes3epZER2cAoN8wJHaM 0c6K7e74rG0Ubl+xM5SdgiFfX0RIitqPBPLvE/Ic8R/XnwjxDmCg4FN5xhq0bSTvJYeG x8Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708325981; x=1708930781; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AfAV24x7YrRfp7a1aPkTeFhdi55Bp5TvgPp9C25tWp0=; b=er5hz2Lv/1W7R6FqAY7RqR4eIrOEWy2Q3kyvUlZxDsYssyEmsM6u5FozgkAqTVHEmn bczJzcULcaZvl3WNec1W1WvovBqVVddlUnFnCMVtv5RjiFBD31YYVApF+0Dg+Dd/PrpQ 68P3sxxBe7lvkut8LrCCmO/RjqzqmVz/12ynVwfm0sJORXw60Mr3RV2x5jNKv+MnJ5hY XsY/vg5fLUtGEJ6rOvSYj+vizK2w9mQKavlpnYdMLHDb30UA6wOtSFZ+sdmlQ0lqlLiP iAJoUufSx6miN2xG2KvUAsfo240WIIdsvis+x746SIUPrXjRX3xV8PbxZu3zAdvx3YQC qyIA== X-Forwarded-Encrypted: i=1; AJvYcCVfuNeuleOqjJ7+HX7kKB9auVvSy/xQXYSMiOujyEFWIdc+AFjxWwUeX12abX8Pvbyz2KDMB5nR4vZ8nnRgqpYiHwjRiLYv5w1Nv5wmjQ== X-Gm-Message-State: AOJu0YzODIVahDuJKEQGvwjpXBrBUuGps9ZErgKre1seh+yTxQp8GRcZ mQp6nqOJ8Rl//jxvtfvJ5rdsvIMZC3aSZM/YRiQ/f8zyD09aS6KX/lZH8ZshC2U= X-Google-Smtp-Source: AGHT+IE/wOzaL7fQihkYqoU1MECC1GWbfyGnRdiNkkmlrFDDTCslsV8yH4p06YEr4kqTduK2N5CsEw== X-Received: by 2002:a05:600c:4fc4:b0:412:16d8:d565 with SMTP id o4-20020a05600c4fc400b0041216d8d565mr8152877wmq.15.1708325980793; Sun, 18 Feb 2024 22:59:40 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.116]) by smtp.gmail.com with ESMTPSA id p11-20020a05600c1d8b00b004126a0dfd11sm113616wms.29.2024.02.18.22.59.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Feb 2024 22:59:40 -0800 (PST) Message-ID: <88de75cd-4069-4be6-9c4e-f32befa46d58@linaro.org> Date: Mon, 19 Feb 2024 07:59:36 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: constify the of_phandle_args argument of of_clk_provider To: claudiu beznea , Michael Turquette , Stephen Boyd , Sudeep Holla , Peng Fan , Shawn Guo , Nishanth Menon , Bjorn Andersson , Konrad Dybcio , Geert Uytterhoeven , Thierry Reding , Jonathan Hunter , Linus Walleij , Laurent Pinchart , Mauro Carvalho Chehab , Vinod Koul , Russell King , Srinivas Kandagatla , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-stm32@st-md-mailman.stormreply.com, NXP Linux Team , linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-media@vger.kernel.org, linux-phy@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org References: <20240208163710.512733-1-krzysztof.kozlowski@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/02/2024 07:25, claudiu beznea wrote: > > > On 08.02.2024 18:37, Krzysztof Kozlowski wrote: >> None of the implementations of the get() and get_hw() callbacks of >> "struct of_clk_provider" modify the contents of received of_phandle_args >> pointer. They treat it as read-only variable used to find the clock to >> return. Make obvious that implementations are not supposed to modify >> the of_phandle_args, by making it a pointer to const. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> drivers/clk/at91/pmc.c | 3 +- >> drivers/clk/at91/pmc.h | 3 +- > > Reviewed-by: Claudiu Beznea You understand there is no review for "part of patch"? You probably meant Acked-by. https://elixir.bootlin.com/linux/v6.8-rc5/source/Documentation/process/submitting-patches.rst#L544 Best regards, Krzysztof