* [PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in hidma_mgmt_init_sys()
@ 2017-04-17 20:55 SF Markus Elfring
2017-04-17 22:23 ` Sinan Kaya
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-04-17 20:55 UTC (permalink / raw)
To: dmaengine, linux-arm-msm, linux-soc, Andy Gross, Dan Williams,
David Brown, Sinan Kaya, Vinod Koul
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Apr 2017 22:42:40 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kmalloc_array".
This issue was detected by using the Coccinelle software.
* Delete the local variable "required" which became unnecessary
with this refactoring.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/dma/qcom/hidma_mgmt_sys.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/qcom/hidma_mgmt_sys.c b/drivers/dma/qcom/hidma_mgmt_sys.c
index d61f1068a34b..e7222a0e9ba4 100644
--- a/drivers/dma/qcom/hidma_mgmt_sys.c
+++ b/drivers/dma/qcom/hidma_mgmt_sys.c
@@ -245,11 +245,12 @@ int hidma_mgmt_init_sys(struct hidma_mgmt_dev *mdev)
{
unsigned int i;
int rc;
- int required;
struct kobject *chanops;
- required = sizeof(*mdev->chroots) * mdev->dma_channels;
- mdev->chroots = devm_kmalloc(&mdev->pdev->dev, required, GFP_KERNEL);
+ mdev->chroots = devm_kmalloc_array(&mdev->pdev->dev,
+ mdev->dma_channels,
+ sizeof(*mdev->chroots),
+ GFP_KERNEL);
if (!mdev->chroots)
return -ENOMEM;
--
2.12.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in hidma_mgmt_init_sys()
2017-04-17 20:55 [PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in hidma_mgmt_init_sys() SF Markus Elfring
@ 2017-04-17 22:23 ` Sinan Kaya
0 siblings, 0 replies; 2+ messages in thread
From: Sinan Kaya @ 2017-04-17 22:23 UTC (permalink / raw)
To: SF Markus Elfring, dmaengine, linux-arm-msm, linux-soc,
Andy Gross, Dan Williams, David Brown, Vinod Koul
Cc: LKML, kernel-janitors
On 4/17/2017 4:55 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 17 Apr 2017 22:42:40 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kmalloc_array".
>
> This issue was detected by using the Coccinelle software.
>
> * Delete the local variable "required" which became unnecessary
> with this refactoring.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/dma/qcom/hidma_mgmt_sys.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/qcom/hidma_mgmt_sys.c b/drivers/dma/qcom/hidma_mgmt_sys.c
> index d61f1068a34b..e7222a0e9ba4 100644
> --- a/drivers/dma/qcom/hidma_mgmt_sys.c
> +++ b/drivers/dma/qcom/hidma_mgmt_sys.c
> @@ -245,11 +245,12 @@ int hidma_mgmt_init_sys(struct hidma_mgmt_dev *mdev)
> {
> unsigned int i;
> int rc;
> - int required;
> struct kobject *chanops;
>
> - required = sizeof(*mdev->chroots) * mdev->dma_channels;
> - mdev->chroots = devm_kmalloc(&mdev->pdev->dev, required, GFP_KERNEL);
> + mdev->chroots = devm_kmalloc_array(&mdev->pdev->dev,
> + mdev->dma_channels,
> + sizeof(*mdev->chroots),
> + GFP_KERNEL);
> if (!mdev->chroots)
> return -ENOMEM;
>
>
Reviewed-by: Sinan Kaya <okaya@codeauora.org>
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-17 22:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-17 20:55 [PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in hidma_mgmt_init_sys() SF Markus Elfring
2017-04-17 22:23 ` Sinan Kaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).