From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64569C10F14 for ; Thu, 3 Oct 2019 15:21:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CC2B2133F for ; Thu, 3 Oct 2019 15:21:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="NiXzjB8P"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Sg9Nov1m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728031AbfJCPVs (ORCPT ); Thu, 3 Oct 2019 11:21:48 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49030 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727587AbfJCPVs (ORCPT ); Thu, 3 Oct 2019 11:21:48 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 93967611BE; Thu, 3 Oct 2019 15:21:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570116107; bh=wrF+mAtbKK35bIsjW1eEOP2bIDJkMLZvW9UvGD8kv0c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NiXzjB8POJq6c49Y2fnoEw68KFMNvPlQJ/7w6vTWJCoAnF5tMXprjguDaFGUlnesy fI2nk9BJxQLEnt7tLz7Ku5+ZKPjzVfwNHZVNlkNn6y2xWwO1ynJa7ILFftggawnfxW 3awHwFDp69wyttHCjer7RzMQ37u6dLBrI35qN2Ik= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 8656760ADE; Thu, 3 Oct 2019 15:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570116106; bh=wrF+mAtbKK35bIsjW1eEOP2bIDJkMLZvW9UvGD8kv0c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sg9Nov1mh/nDNVMzTBKKGarxyT2GpyPeRjsw6o1kLIrwNWXyqGGa4GG+tPttWBVZz lOMOaeM+kR8AVvJSOiPCASZF7YraLRX7dOCgd7kjUlBLIlVd6msmHp9ow43AfS0oCX /Kz0NL+3r1y8coTb8+3SXrUxk/ZMkhNcPatJ19ok= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 03 Oct 2019 20:51:46 +0530 From: Sai Prakash Ranjan To: Marc Gonzalez Cc: Jeffrey Hugo , Rob Herring , Mathieu Poirier , Suzuki K Poulose , Bjorn Andersson , Andy Gross , Mark Rutland , Linux ARM , MSM , DT Subject: Re: [PATCH] arm64: dts: qcom: msm8998: Disable coresight by default In-Reply-To: References: <20191003064449.2201-1-saiprakash.ranjan@codeaurora.org> Message-ID: <89f5f76ae26682e902faa1b06379cc0f@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2019-10-03 18:23, Marc Gonzalez wrote: > On 03/10/2019 08:44, Sai Prakash Ranjan wrote: > >> Boot failure has been reported on MSM8998 based laptop when >> coresight is enabled. This is most likely due to lack of >> firmware support for coresight on production device when >> compared to debug device like MTP where this issue is not >> observed. So disable coresight by default for MSM8998 and >> enable it only for MSM8998 MTP. >> >> Reported-and-tested-by: Jeffrey Hugo >> Fixes: 783abfa2249a ("arm64: dts: qcom: msm8998: Add Coresight >> support") >> Signed-off-by: Sai Prakash Ranjan >> --- >> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 68 >> +++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/msm8998.dtsi | 51 +++++++++++------ >> 2 files changed, 102 insertions(+), 17 deletions(-) > > Just wanted to toss an alternative, based on Suzuki's suggestion > (i.e. move the coresight nodes to a separate file) > > I believe this is a better approach. Initially I had coresight components in a separate file like this but Bjorn had some concerns about having 2 separate files. If he is OK with this, Acked-by: Sai Prakash Ranjan -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation