From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Taniya Das <quic_tdas@quicinc.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Jonathan Marek <jonathan@marek.ca>,
Del Regno <angelogioacchino.delregno@somainline.org>,
Loic Poulain <loic.poulain@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/16] dt-bindings: clock: qcom: reference qcom-gcc.yaml
Date: Fri, 31 May 2024 17:19:19 +0200 [thread overview]
Message-ID: <8ac8cc27-6c39-45fe-bdc2-40a310c815cc@linaro.org> (raw)
In-Reply-To: <l73uszlhnhyamfuwm7f6bbmockttwihsylkkgbyedkdseznlka@mtr5c7r4nqt4>
On 31/05/2024 17:14, Dmitry Baryshkov wrote:
> On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote:
>> Hi,
>>
>> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where
>> applicable. Several existing bindings for these display/GPU/CAM clock
>> controllers already do it.
>
> The series looks good to me with a single point in mind. You are writing
> that dispcc/videocc/etc are a variant of GCC. However GCC is a Global
> Clock Controller.
Yeah, that's simplification from my side and assumption that at first
they designed GCC and then they copied the design to other blocks.
> What about renaming qcom,gcc.yaml to
> qcom,cc-common.yaml ? Then the rest makes total sense to me.
Several gpu/disp/cam clock controllers already include qcom,gcc.yaml, so
I would say this should not be a requirement for this patchset.
We can rename, although it always is a bit of churn - git log needs
special option, backporting is a bit trickier.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-31 15:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 13:52 [PATCH 00/16] dt-bindings: clock: qcom: reference qcom-gcc.yaml Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 01/16] dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 02/16] dt-bindings: clock: qcom,videocc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 03/16] dt-bindings: clock: qcom,dispcc-sc8280xp: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 04/16] dt-bindings: clock: qcom,dispcc-sm6350: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 05/16] dt-bindings: clock: qcom,dispcc-sm8x50: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 06/16] dt-bindings: clock: qcom,gpucc-sdm660: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 07/16] dt-bindings: clock: qcom,gpucc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 08/16] dt-bindings: clock: qcom,msm8998-gpucc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 09/16] dt-bindings: clock: qcom,qcm2290-dispcc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 10/16] dt-bindings: clock: qcom,sc7180-dispcc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 11/16] dt-bindings: clock: qcom,sc7280-dispcc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 12/16] dt-bindings: clock: qcom,sdm845-dispcc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 13/16] dt-bindings: clock: qcom,sm6115-dispcc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 14/16] dt-bindings: clock: qcom,sm8450-dispcc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 15/16] dt-bindings: clock: qcom,sm8550-dispcc: " Krzysztof Kozlowski
2024-05-31 13:52 ` [PATCH 16/16] dt-bindings: clock: qcom,sm8450-gpucc: " Krzysztof Kozlowski
2024-05-31 15:14 ` [PATCH 00/16] dt-bindings: clock: qcom: reference qcom-gcc.yaml Dmitry Baryshkov
2024-05-31 15:19 ` Krzysztof Kozlowski [this message]
2024-05-31 17:39 ` Dmitry Baryshkov
2024-06-02 4:29 ` Bjorn Andersson
2024-06-04 20:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ac8cc27-6c39-45fe-bdc2-40a310c815cc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox