Re: [PATCH RFC 10/11] drm/msm/mdss: Add support for SM8750

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 09/01/2025 23:39, Dmitry Baryshkov wrote:
> On Thu, Jan 09, 2025 at 02:08:37PM +0100, Krzysztof Kozlowski wrote:
>> Add support for the Qualcomm SM8750 platform.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  drivers/gpu/drm/msm/msm_mdss.c | 33 +++++++++++++++++++++++++++++++++
>>  drivers/gpu/drm/msm/msm_mdss.h |  1 +
>>  2 files changed, 34 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
>> index dcb49fd30402b80edd2cb5971f95a78eaad6081f..3f00eb6de3a9d2bee7637c6f516efff78b7d872b 100644
>> --- a/drivers/gpu/drm/msm/msm_mdss.c
>> +++ b/drivers/gpu/drm/msm/msm_mdss.c
>> @@ -222,6 +222,24 @@ static void msm_mdss_setup_ubwc_dec_40(struct msm_mdss *msm_mdss)
>>  	}
>>  }
>>  
>> +static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss *msm_mdss)
>> +{
>> +	const struct msm_mdss_data *data = msm_mdss->mdss_data;
>> +	u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) |
>> +		    MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit);
>> +
>> +	if (data->ubwc_bank_spread)
>> +		value |= MDSS_UBWC_STATIC_UBWC_BANK_SPREAD;
>> +
>> +	if (data->macrotile_mode)
>> +		value |= MDSS_UBWC_STATIC_MACROTILE_MODE;
>> +
>> +	writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC);
>> +
>> +	writel_relaxed(4, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2);
>> +	writel_relaxed(1, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE);
> 
> Nit: this probably can be folded into the msm_mdss_setup_ubwc_dec_40(),
> but I would not require it.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

That was my initial try, but the resulting code was getting big with all
the if-then.

Best regards,
Krzysztof