From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
benl@squareup.com, shawn.guo@linaro.org,
fabien.parent@linaro.org, leo.yan@linaro.org,
dmitry.baryshkov@linaro.org, stephan@gerhold.net,
Jun Nie <jun.nie@linaro.org>,
James Willcox <jwillcox@squareup.com>,
Joseph Gates <jgates@squareup.com>, Max Chen <mchen@squareup.com>,
Zac Crosby <zac@squareup.com>
Subject: Re: [PATCH v4 5/6] arm64: dts: qcom: Add Square apq8039-t2 board
Date: Wed, 25 Jan 2023 01:21:15 +0000 [thread overview]
Message-ID: <8dd1ce3c-82ea-cfc3-a84c-c022cbaec8a0@linaro.org> (raw)
In-Reply-To: <e80b98bc-54e8-f7ab-b9a9-dd888108a0cd@linaro.org>
On 23/01/2023 16:29, Krzysztof Kozlowski wrote:
> On 23/01/2023 03:31, Bryan O'Donoghue wrote:
>> The apq8039-t2 is an apq8039 based board paired with a wcn3680b WiFi
>> chipset.
>>
>> Co-developed-by: Shawn Guo <shawn.guo@linaro.org>
>> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
>> Co-developed-by: Jun Nie <jun.nie@linaro.org>
>> Signed-off-by: Jun Nie <jun.nie@linaro.org>
>> Co-developed-by: Benjamin Li <benl@squareup.com>
>> Signed-off-by: Benjamin Li <benl@squareup.com>
>> Co-developed-by: James Willcox <jwillcox@squareup.com>
>> Signed-off-by: James Willcox <jwillcox@squareup.com>
>> Co-developed-by: Leo Yan <leo.yan@linaro.org>
>> Signed-off-by: Leo Yan <leo.yan@linaro.org>
>> Co-developed-by: Joseph Gates <jgates@squareup.com>
>> Signed-off-by: Joseph Gates <jgates@squareup.com>
>> Co-developed-by: Max Chen <mchen@squareup.com>
>> Signed-off-by: Max Chen <mchen@squareup.com>
>> Co-developed-by: Zac Crosby <zac@squareup.com>
>> Signed-off-by: Zac Crosby <zac@squareup.com>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> arch/arm64/boot/dts/qcom/apq8039-t2.dts | 545 ++++++++++++++++++++++++
>> 2 files changed, 546 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/apq8039-t2.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index b0423ca3e79fd..73ff8d3213d99 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -1,5 +1,6 @@
>> # SPDX-License-Identifier: GPL-2.0
>> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += apq8039-t2.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/apq8039-t2.dts b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
>> new file mode 100644
>> index 0000000000000..734b4d6054132
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
>> @@ -0,0 +1,545 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2020-2023, Linaro Ltd.
>> + *
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "msm8939.dtsi"
>> +#include "msm8939-pm8916.dtsi"
>> +#include <dt-bindings/arm/qcom,ids.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>> +#include <dt-bindings/sound/apq8016-lpass.h>
>> +
>> +/ {
>> + model = "Square, Inc. T2 Devkit";
>> + compatible = "square,apq8039-t2", "qcom,msm8939";
>
> There is no square vendor prefix.
commit d3e2262cd0d1105bb3a71012693876d01e8de203
Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: Tue Jan 17 02:48:39 2023 +0000
dt-bindings: arm: qcom: Document MSM8939 SoC binding
+ - items:
+ - enum:
+ - sony,kanuti-tulip
+ - square,apq8039-t2
+ - const: qcom,msm8939
>> +
>> + qcom,board-id = <0x53 0x54>;
>> + qcom,msm-id = <QCOM_ID_MSM8939 0>, <QCOM_ID_MSM8939 0x30000>, <QCOM_ID_APQ8039 0x30000>;
>> +
>> +
>> + lcd_avdd_reg: lcd-avdd-regulator {
>
> Since we try to have nodes ordered, how about naming them
> "regulator-xxx", so whatever is added later will not spread them all over?
Point taken.
vreg_ looks like a more common prefix
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts:
vreg_edp_3p3: regulator-edp-3p3 {
vreg_edp_bl: regulator-edp-bl {
vreg_misc_3p3: regulator-misc-3p3 {
vreg_nvme: regulator-nvme {
vreg_vph_pwr: regulator-vph-pwr {
vreg_wlan: regulator-wlan {
vreg_wwan: regulator-wwan {
>> + status = "okay";
>> +
>> + typec: tps6598x@38 {
>
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
None of those fit really
typec_pd is upstream for the same IC, I'll reuse that.
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
---
bod
next prev parent reply other threads:[~2023-01-25 1:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 2:31 [PATCH v4 0/6] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-01-23 2:31 ` [PATCH v4 1/6] dt-bindings: clock: msm8939: Move msm8939 to a distinct yaml file Bryan O'Donoghue
2023-01-23 9:06 ` Krzysztof Kozlowski
2023-01-23 13:49 ` Rob Herring
2023-01-23 2:31 ` [PATCH v4 2/6] dt-bindings: interconnect: Exclude all non msm8939 from snoc-mm Bryan O'Donoghue
2023-01-23 2:31 ` [PATCH v4 3/6] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-01-23 2:31 ` [PATCH v4 4/6] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-01-23 2:31 ` [PATCH v4 5/6] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-01-23 16:17 ` Konrad Dybcio
2023-01-23 16:29 ` Krzysztof Kozlowski
2023-01-25 1:21 ` Bryan O'Donoghue [this message]
2023-01-25 1:29 ` Konrad Dybcio
2023-01-25 2:25 ` Bryan O'Donoghue
2023-01-25 7:15 ` Krzysztof Kozlowski
2023-01-23 2:31 ` [PATCH v4 6/6] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2023-01-23 16:19 ` Konrad Dybcio
2023-01-23 11:00 ` [PATCH v4 0/6] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-01-23 11:08 ` Bryan O'Donoghue
2023-01-23 12:49 ` Stephan Gerhold
2023-01-23 13:03 ` Bryan O'Donoghue
2023-01-23 13:23 ` Bryan O'Donoghue
2023-01-23 14:00 ` Stephan Gerhold
2023-01-23 16:14 ` Bryan O'Donoghue
2023-01-23 16:21 ` Konrad Dybcio
2023-01-23 16:29 ` Bryan O'Donoghue
2023-01-26 15:29 ` Bryan O'Donoghue
2023-01-26 15:34 ` Konrad Dybcio
2023-01-26 16:32 ` Bryan O'Donoghue
2023-01-26 16:45 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dd1ce3c-82ea-cfc3-a84c-c022cbaec8a0@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=jgates@squareup.com \
--cc=jun.nie@linaro.org \
--cc=jwillcox@squareup.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchen@squareup.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stephan@gerhold.net \
--cc=zac@squareup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).