Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pavan Kondeti <pavan.kondeti@oss.qualcomm.com>,
	Guenter Roeck <linux@roeck-us.net>
Cc: hrishabh.rajput@oss.qualcomm.com,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v3] watchdog: Add driver for Gunyah Watchdog
Date: Tue, 28 Oct 2025 17:45:56 +0100	[thread overview]
Message-ID: <8dd2a196-e15b-4b1b-bebe-fcb6445d427b@kernel.org> (raw)
In-Reply-To: <3e4fd54c-90fb-4b15-a9cd-a2d11b0aa952@quicinc.com>

On 28/10/2025 17:40, Pavan Kondeti wrote:
>> Every other driver which supports devicetree has an .of_match_table
>> which triggers device instantiation. If the Gunyah watchdog can for
>> some reason not use that approach, its devicetree description should
>> be fixed. Instantiating the device from its init function because its
>> devicetree description is bad or missing is just wrong. It is even more
>> wrong to try to contact the hardware or embedded controller to figure out
>> if the device is there. This can have all kinds of negative impact on other
>> hardware.
>>
> The Gunyah WDT node gets overlayed by bootloader. We see that this

We absolutely don't care what your bootloader gives as overlay. You
should have first define the bindings then add such stuff.

You cannot use any argument of your bootloader in such case. You decided
to do it ignoring or not even asking community, so you have to live now
with all the consequences of it. Including rewriting completely bootloader.


> overlay is failing w/ upstream device tree since the overlay has
> references to downstream code. Please see [1]. Hence we are trying to
> register the platform device dynamically.


Best regards,
Krzysztof

  reply	other threads:[~2025-10-28 16:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  9:35 [PATCH v3] watchdog: Add driver for Gunyah Watchdog Hrishabh Rajput via B4 Relay
2025-10-28  9:40 ` Krzysztof Kozlowski
2025-10-28 10:58   ` Hrishabh Rajput
2025-10-28 11:04     ` Krzysztof Kozlowski
2025-10-28 11:07       ` Krzysztof Kozlowski
2025-10-28 12:27         ` Pavan Kondeti
2025-10-28 16:17           ` Krzysztof Kozlowski
2025-10-28 16:29             ` Krzysztof Kozlowski
2025-10-28 16:33             ` Pavan Kondeti
2025-10-28 16:39               ` Neil Armstrong
2025-10-28 17:03                 ` Pavan Kondeti
2025-10-28 16:40               ` Krzysztof Kozlowski
2025-10-28 16:51                 ` Dmitry Baryshkov
2025-10-28 16:53                   ` Krzysztof Kozlowski
2025-10-28 17:07                     ` Pavan Kondeti
2025-10-28 16:30           ` Neil Armstrong
2025-10-28 16:36             ` Pavan Kondeti
2025-10-28 16:06 ` Guenter Roeck
2025-10-28 16:40   ` Pavan Kondeti
2025-10-28 16:45     ` Krzysztof Kozlowski [this message]
2025-10-28 17:29     ` Guenter Roeck
2025-10-28 17:49       ` Pavan Kondeti
2025-10-28 16:44   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8dd2a196-e15b-4b1b-bebe-fcb6445d427b@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hrishabh.rajput@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=neil.armstrong@linaro.org \
    --cc=pavan.kondeti@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox