From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1784EC38142 for ; Tue, 31 Jan 2023 12:38:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231460AbjAaMiQ (ORCPT ); Tue, 31 Jan 2023 07:38:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231907AbjAaMiM (ORCPT ); Tue, 31 Jan 2023 07:38:12 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3866C3EFC0 for ; Tue, 31 Jan 2023 04:38:03 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id qw12so25263180ejc.2 for ; Tue, 31 Jan 2023 04:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IKxbXbEULBKOHnps7S4m6S4/h0JUMvMF27+rV1zb/eY=; b=KoQK4BP+iUuerkkYupPQ6Mfvtfw+GCDZgMZNWp3fj+UhiBjoITRpmFXWpZIkOqIu3o Lc2EsgPGLh6reRhpPZY0PcmnKo2V5l2pcLIkTEXKZRWFBbaKBJBUy9uO+44HiqM1dIgt uJ8gqAa5NcErmSLuyDIPhKk3VLZQ7M+eCBFNN/OwqhBIdkUU0rzR24l6fgcZp6VhWsU0 cBsEc7T5tmSExLTiC3LmqVuqvGqFAwG+EWBw9KEbP1xBWsra6fGUuQIYtnfeFPuDdi9n m2TMoX/uXM80Nva6rNxYmJcnoZ1dBNOrEur5JIhiPMmvi0IrJ9+/0d/Rl0aPR9Jv/Sch DMTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IKxbXbEULBKOHnps7S4m6S4/h0JUMvMF27+rV1zb/eY=; b=XAu9r8dS+l8emDFBeORJt2XNGx76JjJneZh8rLn7uwmPWCMQp1TEcDpgfULFTbwj2w ZG6q+jUlJ7a8+COwOxnKx6NN6WzKGYfcIq9kNqN3PlUFcrZY6q/huzeL3yB8yjwX0f36 BvX2LrA8dd/Xi3duyf3YPWX9xRRPYlBwJIV2vELVm8MsWsiSlKfaxoWsxl/5uINp/RRZ AJMKqNE8QfI4rYVuGyIjjFAfqF3jcAJkXvRQDcx99no1PsfAuNO2Gh64F8PZbzccyZ9n dt7CmPbpD9lGdaWMYKTJ5V8i4SUXsocQgX7SH6/4MwdtCkxWMnI9U6hCPcqTEXlJ08Dm uLaA== X-Gm-Message-State: AO0yUKXM667F0zLi8h76AIfowvJb1NsF98T9oE36JJQ8s8234dOWzMZU w5Z0GUZ4DDPVj0M9pZ/CQfIgUg== X-Google-Smtp-Source: AK7set+tpLdZpV3Lq1clFGcWzNITzxmhts98f/KIaiISBd86thLtpFk5vBVlowdEYD8yiRezgckW1Q== X-Received: by 2002:a17:907:1c84:b0:889:b6ae:75fe with SMTP id nb4-20020a1709071c8400b00889b6ae75femr3706521ejc.61.1675168681710; Tue, 31 Jan 2023 04:38:01 -0800 (PST) Received: from [192.168.1.101] (abyl20.neoplus.adsl.tpnet.pl. [83.9.31.20]) by smtp.gmail.com with ESMTPSA id s9-20020a170906a18900b0088519b92074sm4504437ejy.128.2023.01.31.04.38.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 04:38:01 -0800 (PST) Message-ID: <8e11a80c-8056-e226-e051-c01b82f29d05@linaro.org> Date: Tue, 31 Jan 2023 13:37:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v4 4/8] clk: qcom: Add GPU clock controller driver for SM6125 Content-Language: en-US To: Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20230130235926.2419776-1-konrad.dybcio@linaro.org> <20230130235926.2419776-5-konrad.dybcio@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 31.01.2023 10:00, Dmitry Baryshkov wrote: > On 31/01/2023 01:59, Konrad Dybcio wrote: >> Add support for the GPU clock controller found on SM6125. >> >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Konrad Dybcio >> --- [...] >> +    /* Set recommended WAKEUP/SLEEP settings for the gpu_cc_cx_gmu_clk */ >> +    regmap_update_bits(regmap, gpu_cc_cx_gmu_clk.clkr.enable_reg, CBCR_WAKEUP, 0xf); >> +    regmap_update_bits(regmap, gpu_cc_cx_gmu_clk.clkr.enable_reg, CBCR_SLEEP, 0xf); > > I think you have to use FIELD_PREP here. regmap_update_bits doesn't shift the value according to the mask, does it? > You're right. Konrad >> + >> +    qcom_branch_set_force_mem_core(regmap, gpu_cc_gx_gfx3d_clk.halt_reg, true); >> +    qcom_branch_set_force_periph_on(regmap, gpu_cc_gx_gfx3d_clk.halt_reg, true); >> + >> +    return qcom_cc_really_probe(pdev, &gpu_cc_sm6125_desc, regmap); >> +} >> + >> +static struct platform_driver gpu_cc_sm6125_driver = { >> +    .probe = gpu_cc_sm6125_probe, >> +    .driver = { >> +        .name = "gpucc-sm6125", >> +        .of_match_table = gpu_cc_sm6125_match_table, >> +    }, >> +}; >> +module_platform_driver(gpu_cc_sm6125_driver); >> + >> +MODULE_DESCRIPTION("QTI GPUCC SM6125 Driver"); >> +MODULE_LICENSE("GPL"); >