From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2166C77B7F for ; Fri, 19 May 2023 10:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231448AbjESKNP (ORCPT ); Fri, 19 May 2023 06:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbjESKNO (ORCPT ); Fri, 19 May 2023 06:13:14 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FF081AD for ; Fri, 19 May 2023 03:13:12 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-64d3bc502ddso245578b3a.0 for ; Fri, 19 May 2023 03:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684491192; x=1687083192; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BSr7GdXWAJku5Kok/w8KozBJgW/7oVgHlXu4LnQYU4U=; b=AMYwSYKjD74G4Sw9tPc/nRaoL17u7EvGnGODVSfNhloK/SPeeqRD/GT1KCyKJg2Omz eGIQemeDf5Tp/uGNuMICegZqzEvI2IThIZt23UyHiXLNXV69Epl/EyfBbJ5fGMEgJxpe fykU5WMP1StVgRHUrIxCeuIn5oCBg9YwwY7o4Du9FeZ39gRWPwa5HOVux9DCdi5GNv4F WXQ29NIgBQ9H/ufW3/IzAYS/FLw8jbcxsgS+HYQJK6wt+CNNQQUjGu6kYBrwq1UVCig0 knv/dg9Ia25SXp88Ykh7NRtrRs3uKAwAyQM6R6ILcu8prQ3Q7mO3Il08Xh7dAF2g+GcN B1Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684491192; x=1687083192; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BSr7GdXWAJku5Kok/w8KozBJgW/7oVgHlXu4LnQYU4U=; b=SCYgYC/N5IvPMdlodwiXzrgU5VCR9qRhhOJ6jRuit+jTSKbU/oOT0W6iPmkhEK3SMo SiFBibIdGu9NFNpGKKjnyKMZMc2DBlPFU4XPb76+yOZVQw5eBjwhULj1RNOnKAYjYLo9 nqg70d+JvkL4ZPlkj7bsYkEaKRiJs4AQa3DFOFv7eulMBvIUrouQ+wE/owfPmRBLazR3 PKLy8VdzMP5QvVmVkuvBw9BvXZYAtGBeXNupdM8oDW0MoRxzYoBgoLc5GCFzxAEbZkPz qQJGEXw/AzNO/AfoU+A/U8aZPL4D7F8SfDZYIpVr6pfFfvbIuylcTOx/OY/d40v3yaN+ K/rA== X-Gm-Message-State: AC+VfDzESJ/iNihaCO5MVTkpoTJhs808dK4F196a4TB3ik/2uTEb5Y0y DgPecz/ftBntp4Bv0g6zcXv1sw== X-Google-Smtp-Source: ACHHUZ5kIqy1tdfgOlJbIVGQKOPxbA7vVEAaQIQrUfkKpzzN8ZCX1hfQmxBOMBUcHovpjekE6/JZTg== X-Received: by 2002:a05:6a20:3d09:b0:104:a096:6ac7 with SMTP id y9-20020a056a203d0900b00104a0966ac7mr1962172pzi.34.1684491192074; Fri, 19 May 2023 03:13:12 -0700 (PDT) Received: from ?IPV6:2401:4900:1c60:d309:883d:817e:8e91:be39? ([2401:4900:1c60:d309:883d:817e:8e91:be39]) by smtp.gmail.com with ESMTPSA id p15-20020aa7860f000000b0064d35776709sm732016pfn.78.2023.05.19.03.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 03:13:11 -0700 (PDT) Message-ID: <8e3c745a-2e37-2927-7dbf-e23a777702f3@linaro.org> Date: Fri, 19 May 2023 15:43:06 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc Content-Language: en-US To: Komal Bajaj , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230519085122.15758-1-quic_kbajaj@quicinc.com> <20230519085122.15758-5-quic_kbajaj@quicinc.com> From: Bhupesh Sharma In-Reply-To: <20230519085122.15758-5-quic_kbajaj@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/19/23 2:21 PM, Komal Bajaj wrote: > Add sdhci node for emmc in qdu1000-idp. > > Signed-off-by: Komal Bajaj > --- > arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > index 9e9fd4b8023e..b2526e991548 100644 > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > @@ -451,3 +451,14 @@ > &uart7 { > status = "okay"; > }; > + > +&sdhc_1 { > + status = "okay"; > + > + pinctrl-0 = <&sdc1_on_state>; > + pinctrl-1 = <&sdc1_off_state>; > + pinctrl-names = "default", "sleep"; > + > + vmmc-supply = <&vreg_l10a_2p95>; > + vqmmc-supply = <&vreg_l7a_1p8>; > +}; Again, please follow alphabetical order for adding new node entries. Also, we have been placing 'status = .. ' entry at the end for new .dts (or .dts entry), but if that is the format used across this board dts I am ok with the same. Thanks, Bhupesh