From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Nikita Travkin <nikita@trvn.ru>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Drop CMA heap
Date: Thu, 27 Feb 2025 16:04:20 +0000 [thread overview]
Message-ID: <8e778221-bec2-437f-b51a-b665ad2ed405@linaro.org> (raw)
In-Reply-To: <20250227-qcom-nonroot-overlays-v2-2-bde44f708cbe@trvn.ru>
On 27/02/2025 14:26, Nikita Travkin wrote:
> Initially added, the cma heap was supposed to help with libcamera swisp,
> however a mistake was made such that the node was never applied as part
> of the overlay since the change was added to the overlay root ("/") and
> not with a reference to the target dtb root ("&{/}"). Moveover libcamera
> doesn't require CMA heap on Qualcomm platforms anymore as it can now use
> UDMA buffers instead.
>
> Drop the CMA heap node. This change has no effect on the final dtb.
>
> This reverts commit d40fd02c1faf8faad57a7579b573bc5be51faabe.
>
> Fixes: d40fd02c1faf ("arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add cma heap for libcamera softisp support")
> Suggested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
> ---
> .../boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> index 59970082da45203311146cc5249298f6188bf67a..51f1a4883ab8f0ee7c66fab89c6e1a88c868d2f8 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso
> @@ -9,17 +9,6 @@
> #include <dt-bindings/clock/qcom,camcc-sdm845.h>
> #include <dt-bindings/gpio/gpio.h>
>
> -/ {
> - reserved-memory {
> - linux,cma {
> - compatible = "shared-dma-pool";
> - size = <0x0 0x8000000>;
> - reusable;
> - linux,cma-default;
> - };
> - };
> -};
> -
> &camss {
> vdda-phy-supply = <&vreg_l1a_0p875>;
> vdda-pll-supply = <&vreg_l26a_1p2>;
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2025-02-27 16:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 14:26 [PATCH v2 0/2] {vision/navigation}-mezzanine: Fix overlay root node Nikita Travkin
2025-02-27 14:26 ` [PATCH v2 1/2] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Drop CMA heap Nikita Travkin
2025-02-27 16:04 ` Bryan O'Donoghue
2025-02-27 14:26 ` [PATCH v2 2/2] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: " Nikita Travkin
2025-02-27 16:04 ` Bryan O'Donoghue [this message]
2025-03-04 17:00 ` [PATCH v2 0/2] {vision/navigation}-mezzanine: Fix overlay root node Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e778221-bec2-437f-b51a-b665ad2ed405@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox