From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH 3/3] [v6] pinctrl: qcom: qdf2xxx: add support for new ACPI HID QCOM8002 Date: Thu, 4 Jan 2018 09:46:18 -0600 Message-ID: <8e985f68-5887-b0d5-8c45-e22b5d8f60cf@codeaurora.org> References: <6ca3b4a6-90b9-0481-beb8-29a95c86f07c@codeaurora.org> <615426d4-7c46-9671-87ef-790fb5733385@codeaurora.org> <20171219023935.GA17456@codeaurora.org> <735d4316-9b18-2903-aabd-46ead1db5233@codeaurora.org> <20171220022626.GH7997@codeaurora.org> <20171220081556.GA30524@codeaurora.org> <20171221003947.GJ7997@codeaurora.org> <38463c81-eeab-85dc-d197-6081ce1d1130@codeaurora.org> <20171222014633.GD7997@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171222014633.GD7997@codeaurora.org> Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org To: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Linus Walleij , Andy Shevchenko , Mika Westerberg , thierry.reding@gmail.com, david.brown@linaro.org, andy.gross@linaro.org, Bjorn Andersson , Varadarajan Narayanan , Archit Taneja List-Id: linux-arm-msm@vger.kernel.org On 12/21/2017 07:46 PM, Stephen Boyd wrote: > Ok. That's testable with acpi_match_device_ids() though. I can > add that into pinctrl-msm.c so we don't have to pass info about > available gpios from ACPI specific driver into the pinctrl-msm > core driver. That's why I'm trying to avoid doing it in the ACPI > specific driver. Do it close to where the gpiochip is created > instead. I guess we're just going to have to agree to disagree. I see the DSDs as being SOC-specific, and therefore belong in the SOC driver. I'm still going to need an SOC driver to define the TLMM register layout. But as I said earlier, I've already spent way too much time working on a driver that, in all likelihood, never be used in any production system anyway. I look forward to reviewing the next version of your patch. > Maybe future HIDs could follow the DT design and then we can look > for the same device property name in both firmwares. DSDs generally don't have the vendor prefix that DT properties do. > Parsing > ranges is simpler. I'm not sure I agree with that. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.