From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dzmitry Sankouski <dsankouski@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sagit: add initial device tree for sagit
Date: Mon, 8 Aug 2022 09:10:50 +0300 [thread overview]
Message-ID: <8ee994fc-c5a5-804f-16b7-3502f25b5a53@linaro.org> (raw)
In-Reply-To: <CABTCjFBb1A9+FT6dcid7Fh-+68eh4u2CMUp+-YiQCGUJRCAgnA@mail.gmail.com>
On 05/08/2022 16:06, Dzmitry Sankouski wrote:
> сб, 18 июн. 2022 г. в 04:54, Krzysztof Kozlowski <
> krzysztof.kozlowski@linaro.org>:
>
>> On 17/06/2022 05:20, Dzmitry Sankouski wrote:
>>> New device support - Xiaomi Mi6 phone
>>>
>>> What works:
>>> - storage
>>> - wlan
>>> - touchscreen
>>>
>>> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>>> .../boot/dts/qcom/msm8998-xiaomi-sagit.dts | 12 +
>>> .../boot/dts/qcom/msm8998-xiaomi-sagit.dtsi | 628 ++++++++++++++++++
>>> 3 files changed, 641 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
>>> create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile
>> b/arch/arm64/boot/dts/qcom/Makefile
>>> index 2f8aec2cc6db..aa50843dbe12 100644
>>> --- a/arch/arm64/boot/dts/qcom/Makefile
>>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>>> @@ -48,6 +48,7 @@ dtb-$(CONFIG_ARCH_QCOM) +=
>> msm8998-oneplus-dumpling.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-lilac.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb
>>> +dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb
>>> diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
>> b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
>>> new file mode 100644
>>> index 000000000000..0791615ec5da
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
>>> @@ -0,0 +1,12 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/* Copyright (c) 2016, The Linux Foundation. All rights reserved. */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "msm8998-xiaomi-sagit.dtsi"
>>> +
>>> +/ {
>>> + model = "Xiaomi Mi 6";
>>> + compatible = "xiaomi,sagit", "qcom,msm8998";
>>
>> You need to document the compatible.
>>
> You mean a document file with all msm8998 boards compatible properties
> info, like for example, stm did in
> Documentation/devicetree/bindings/arm/stm32/stm32.yaml ?
I mean, add it to existing bindings with Qualcomm board compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-08 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 12:20 [PATCH] arm64: dts: qcom: sagit: add initial device tree for sagit Dzmitry Sankouski
2022-06-18 1:54 ` Krzysztof Kozlowski
[not found] ` <CABTCjFBb1A9+FT6dcid7Fh-+68eh4u2CMUp+-YiQCGUJRCAgnA@mail.gmail.com>
2022-08-08 6:10 ` Krzysztof Kozlowski [this message]
2022-06-18 23:49 ` Konrad Dybcio
2022-06-19 11:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee994fc-c5a5-804f-16b7-3502f25b5a53@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dsankouski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).