From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF6E3281344 for ; Tue, 20 May 2025 19:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747768909; cv=none; b=lBkpTgdho9JSmUwB6Paf/5sfAlHnoQ0ThNDApPy2QCkFIMjW7rFBFrtRBj2Z5K1rpueyy5nsCbCOoL42Gh/rdZoi+uJA61xWNmD2Ru/vL1GxnkyHEEVeQeoa5RfeHIVIK6lvssQ9diplRRvQXKvFbOGUngE29SDrgWbxW9SBafc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747768909; c=relaxed/simple; bh=BDitTtRWvIz2UMDQvJ11zwEAcrvBiBZ8hWp1th8DRps=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WiUOvETJfW/6srPpId6GoGvVagQu5JL8KJzKn/Dpz9Crj+jf6xOVpU7N4i0LmwIGEYLWFhYuNq7wERjEDARv1GMVnUM0lrVJ0mIjaTWT6FzB9NJa/B9Sl1VOP2+lki7lDqhu2GNSBANEna4g59NDInsC9h3RNsMiDHfARJs19TM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LgOEdokE; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LgOEdokE" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-442eb5d143eso59861875e9.0 for ; Tue, 20 May 2025 12:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747768904; x=1748373704; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GisGtYp9H5pY8mpY2FEw65OMLHF45oHVcxojdMvrrr4=; b=LgOEdokEHY1RDDxhaJbVBbRtjmEpojzSPyy+nRvddHdAzCAYe5KmMIUgwLO8/e4HYO LGNzyRYxWbmqrBiLP1k3LjHcFtD/F78s3ZIufEkDpEsdPtf6eM8/lBGo48CdJ4xx+I3I 2bEmPj4MUyswItcb1dRDjHGwSh+EyFDr5Jcsd7nYYLj9kOgeopXdhZ3z7z1TnFl3QJnz kwA1qzNc3KZfs0nY1s6Q6K7MpoBgQIt0elIf2Qiyln3zacxomnA10TqDSEy1OQ4kwd87 43wbMXrWj1GoxPWcgUPtcIi3TOrMArHJIab42PLfbWEjUKhl6oex5ehUC60VY4dIYwFJ H47w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747768904; x=1748373704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GisGtYp9H5pY8mpY2FEw65OMLHF45oHVcxojdMvrrr4=; b=jsDMLG2TwZyOp8jYh2YhV7/PZ+eBSwIEpfHRyNJ2J+oZKzStUYKci+rgIyINVasj5R hx6x5mR9tfOm6QENLJs8SUzlGt/84sGRPNrVNSootcAjciT+fZkzN+U2DnM/Kx6Z6M/z 1v/LHCOZhQSPjsZ4w2y6IHnlL3zxyKAt0Rt1zd3G6W4ZYLFtMVcrskmozcOSde+ir3vo JLAeVQ/GbepGKF9TImYgZisUOtWrbJ+gGDqE29otmVsqpy153J8id59hja4ZkAvaanph H9CaYKANNYBkxEjfdz7XR4iAQo9JmXjkuJTj9VA+RXgg79wBlWvfJuHnrvW1rAS+/odt dpXQ== X-Forwarded-Encrypted: i=1; AJvYcCW+epBaeV0MMDDJ12dn4DIR4V01nUTTEDGgX3Th8QYzUdZmvvlnB9ac9/SjZ6QwlvBv3IKvyfP2rOKtqgAW@vger.kernel.org X-Gm-Message-State: AOJu0YxEe7UFZ5z2ccXU9558CmNPk5jYTIg1oh2Bzk75DrWPS3QDEvGX JgC/YUjaUOSyWKmd6AYQxMBa5LDjJTMdbASCngp55Jza8OaVDs6kjPqxwe2X7W6Hd/UxJd9SCdN cHXq/+LI= X-Gm-Gg: ASbGncuyKUslB6JRGs4LPu+FEkZuOnvl8w0FzQ36TQW22oQWY8BBt9BsOMswVPq4WS2 AHvTCsowWE2mOr6yxHDD+EVucsucM58rdPOJVqEVvYZjWbw9Vj3aSkUOHRF78lWzPBEEBiGLbQo 84qkYyC1t7m2068PtMY73NWFd9pxO2N4ol0zK2+/hQZJ9Lvp9bMJaoZsX0iRgBURLc0dP+Xu5Ev l6CXEDidJCo2m9vXHR/Qb9aMlwF+MgdDsD+YeBmHZcGUA52o4RIL41Pi0oa76OENYZhFt4ePLM8 bnTIAFJhxE9IFfCyhEHYU2g0U5OQX8LYSx9CfNw8/mcmirVUGupjtnpvTudiPif4U+LkUyXmaWd xzk3thT52DPHndDc5 X-Google-Smtp-Source: AGHT+IHY2rdorKPlsReEga2AUsycUHpEvjBSidFBsgJz9bbiCz4Cm/MX+//BE7dn2/65SPisNxGrpw== X-Received: by 2002:a05:600c:524d:b0:442:e109:3027 with SMTP id 5b1f17b1804b1-442fd6649bdmr161791585e9.24.1747768903979; Tue, 20 May 2025 12:21:43 -0700 (PDT) Received: from [192.168.0.34] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447eee9d8desm43924795e9.0.2025.05.20.12.21.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 12:21:43 -0700 (PDT) Message-ID: <8f5b390c-05ab-4033-9711-3ea7d97e9d5e@linaro.org> Date: Tue, 20 May 2025 20:21:42 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] media: dt-bindings: Add qcom,msm8939-camss To: vincent.knecht@mailoo.org, Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20250520-camss-8x39-vbif-v1-0-a12cd6006af9@mailoo.org> <20250520-camss-8x39-vbif-v1-3-a12cd6006af9@mailoo.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250520-camss-8x39-vbif-v1-3-a12cd6006af9@mailoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/05/2025 19:39, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Signed-off-by: Vincent Knecht > --- > .../bindings/media/qcom,msm8939-camss.yaml | 269 +++++++++++++++++++++ > 1 file changed, 269 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..e300b2c84971a45cca43366817a5ed70f9bae630 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,msm8939-camss.yaml > @@ -0,0 +1,269 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,msm8939-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm MSM8939 Camera Subsystem (CAMSS) > + > +maintainers: > + - Vincent Knecht > + > +description: > + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms > + > +properties: > + compatible: > + const: qcom,msm8939-camss > + > + clocks: > + minItems: 24 > + maxItems: 24 > + > + clock-names: > + items: > + - const: top_ahb > + - const: ispif_ahb > + - const: csiphy0_timer > + - const: csiphy1_timer > + - const: csi0_ahb > + - const: csi0 > + - const: csi0_phy > + - const: csi0_pix > + - const: csi0_rdi > + - const: csi1_ahb > + - const: csi1 > + - const: csi1_phy > + - const: csi1_pix > + - const: csi1_rdi > + - const: csi2_ahb > + - const: csi2 > + - const: csi2_phy > + - const: csi2_pix > + - const: csi2_rdi > + - const: ahb > + - const: vfe0 > + - const: csi_vfe0 > + - const: vfe_ahb > + - const: vfe_axi > + > + interrupts: > + minItems: 7 > + maxItems: 7 > + > + interrupt-names: > + items: > + - const: csiphy0 > + - const: csiphy1 > + - const: csid0 > + - const: csid1 > + - const: csid2 > + - const: ispif > + - const: vfe0 > + > + iommus: > + maxItems: 1 > + > + power-domains: > + items: > + - description: VFE GDSC - Video Front End, Global Distributed Switch Controller. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + description: > + CSI input ports. > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port for receiving CSI data. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + bus-type: > + enum: > + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY > + > + required: > + - data-lanes > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port for receiving CSI data. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + bus-type: > + enum: > + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY > + > + required: > + - data-lanes > + > + reg: > + minItems: 11 > + maxItems: 11 > + > + reg-names: > + items: > + - const: csiphy0 > + - const: csiphy0_clk_mux > + - const: csiphy1 > + - const: csiphy1_clk_mux > + - const: csid0 > + - const: csid1 > + - const: csid2 > + - const: ispif > + - const: csi_clk_mux > + - const: vfe0 > + - const: vfe0_vbif > + > + vdda-supply: > + description: > + Definition of the regulator used as analog power supply. > + > +required: > + - clock-names > + - clocks > + - compatible > + - interrupt-names > + - interrupts > + - iommus > + - power-domains > + - reg > + - reg-names > + - vdda-supply > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + camss: camss@1b0ac00 { > + compatible = "qcom,msm8939-camss"; > + > + clocks = <&gcc GCC_CAMSS_TOP_AHB_CLK>, > + <&gcc GCC_CAMSS_ISPIF_AHB_CLK>, > + <&gcc GCC_CAMSS_CSI0PHYTIMER_CLK>, > + <&gcc GCC_CAMSS_CSI1PHYTIMER_CLK>, > + <&gcc GCC_CAMSS_CSI0_AHB_CLK>, > + <&gcc GCC_CAMSS_CSI0_CLK>, > + <&gcc GCC_CAMSS_CSI0PHY_CLK>, > + <&gcc GCC_CAMSS_CSI0PIX_CLK>, > + <&gcc GCC_CAMSS_CSI0RDI_CLK>, > + <&gcc GCC_CAMSS_CSI1_AHB_CLK>, > + <&gcc GCC_CAMSS_CSI1_CLK>, > + <&gcc GCC_CAMSS_CSI1PHY_CLK>, > + <&gcc GCC_CAMSS_CSI1PIX_CLK>, > + <&gcc GCC_CAMSS_CSI1RDI_CLK>, > + <&gcc GCC_CAMSS_CSI2_AHB_CLK>, > + <&gcc GCC_CAMSS_CSI2_CLK>, > + <&gcc GCC_CAMSS_CSI2PHY_CLK>, > + <&gcc GCC_CAMSS_CSI2PIX_CLK>, > + <&gcc GCC_CAMSS_CSI2RDI_CLK>, > + <&gcc GCC_CAMSS_AHB_CLK>, > + <&gcc GCC_CAMSS_VFE0_CLK>, > + <&gcc GCC_CAMSS_CSI_VFE0_CLK>, > + <&gcc GCC_CAMSS_VFE_AHB_CLK>, > + <&gcc GCC_CAMSS_VFE_AXI_CLK>; > + > + clock-names = "top_ahb", > + "ispif_ahb", > + "csiphy0_timer", > + "csiphy1_timer", > + "csi0_ahb", > + "csi0", > + "csi0_phy", > + "csi0_pix", > + "csi0_rdi", > + "csi1_ahb", > + "csi1", > + "csi1_phy", > + "csi1_pix", > + "csi1_rdi", > + "csi2_ahb", > + "csi2", > + "csi2_phy", > + "csi2_pix", > + "csi2_rdi", > + "ahb", > + "vfe0", > + "csi_vfe0", > + "vfe_ahb", > + "vfe_axi"; The ordering should be alphanum sorted. > + interrupts = , > + , > + , > + , > + , > + , > + ; > + > + interrupt-names = "csiphy0", > + "csiphy1", > + "csid0", > + "csid1", > + "csid2", > + "ispif", > + "vfe0"; > + > + iommus = <&apps_iommu 3>; > + > + power-domains = <&gcc VFE_GDSC>; > + > + reg = <0x01b0ac00 0x200>, > + <0x01b00030 0x4>, > + <0x01b0b000 0x200>, > + <0x01b00038 0x4>, > + <0x01b08000 0x100>, > + <0x01b08400 0x100>, > + <0x01b08800 0x100>, > + <0x01b0a000 0x500>, > + <0x01b00020 0x10>, > + <0x01b10000 0x1000>, > + <0x01b40000 0x200>; > + > + reg-names = "csiphy0", > + "csiphy0_clk_mux", > + "csiphy1", > + "csiphy1_clk_mux", > + "csid0", > + "csid1", > + "csid2", > + "ispif", > + "csi_clk_mux", > + "vfe0", > + "vfe0_vbif"; > + > + vdda-supply = <®_2v8>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + }; >