From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7AC1C6FD18 for ; Tue, 18 Apr 2023 12:19:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjDRMTr (ORCPT ); Tue, 18 Apr 2023 08:19:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbjDRMTq (ORCPT ); Tue, 18 Apr 2023 08:19:46 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1252E44 for ; Tue, 18 Apr 2023 05:19:44 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4ec81773cf7so2106998e87.2 for ; Tue, 18 Apr 2023 05:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681820383; x=1684412383; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K++As7i154zwy5IfL3jSAA+dS+SNhRonUKRKEBDZdQo=; b=GBNnT2+EtV8AGVfQXoStAHMhcq6vQHNGBuNRiGlipr+QXcMxV5CK6FbJlFQzvgPSkh i0b3FbYhA+oUa2fbANSUyMopARHbAQI70pQI52R8IM9YTs/1EGUd1PDy1L84vnTB952e ot0hGQQJpg88huZFyxCwK0ZfAZfu9QbhwWDkS1ckS4II20yWHtIcFI67zqrpTCdcIX1O OlRLTTTmv9QAiL1JnXmGiKDaryBgPrjtK6zLXunEohOYj/M25Xr2TVUVroGEj2aqRotW B51J3Rdx6htFe/QMo8Tl5K+DzLW7DCgq2oOw8+8kTWIBLfa8uTpKkekQEaRh1mRBKvoQ 0wxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681820383; x=1684412383; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K++As7i154zwy5IfL3jSAA+dS+SNhRonUKRKEBDZdQo=; b=JBxlduq5joN0vuNrK3tUZCdRRzjc8RUAgqfyXkTljRCG6rOdrpLqOtjtD6b2PK85Bv HR7IQEOJ/caRSmijYgT5/YUL08/OJ2nWpnPtvkXBnxDmvgGa8U6aSfmytqtvdXNQCIhz yn5XLE9Zf2pFvuRv33S5qmLQfulBSFC+Xe26BKjwHcNAI6PK6Iw0Q5SUrhOmcbkHfenT CBKPY7phsNyzkpcKoWoVR5jxOuJncpap1pCAFgSGAs2RUY7Pmd/LYoTl1ulY/Q8DRnJD qHxH6WE+xUidPcEbQ0y4YEGFmL96EALw1uJkwonejFqut8x8XwB6v81naaKwSgyOpxG+ Sy8w== X-Gm-Message-State: AAQBX9d9J0F9PWfKeeKX35tDf5+YBKosJ6RCMMB9SOuMyZDCOOMlBrbO ibfQkvqPDs8CesB1WtoH4rwRDg== X-Google-Smtp-Source: AKy350YFhqTX/v70GkNmfk43WzugSNGIvy7NEj5Czhf3tsNe3Jr27fQf5XWxWxVoVhNiYZMv41h2gw== X-Received: by 2002:ac2:5e83:0:b0:4eb:2643:c6c6 with SMTP id b3-20020ac25e83000000b004eb2643c6c6mr2836780lfq.53.1681820383155; Tue, 18 Apr 2023 05:19:43 -0700 (PDT) Received: from [192.168.1.101] (abyj144.neoplus.adsl.tpnet.pl. [83.9.29.144]) by smtp.gmail.com with ESMTPSA id s15-20020ac25fef000000b004ec8b638115sm2355741lfg.193.2023.04.18.05.19.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 05:19:42 -0700 (PDT) Message-ID: <8fa0d582-8c1d-5436-ca53-c31badd2f459@linaro.org> Date: Tue, 18 Apr 2023 14:19:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 08/17] drm/msm/dpu: Drop unused poll_timeout_wr_ptr PINGPONG callback Content-Language: en-US To: Marijn Suijten , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Adam Skladowski , Loic Poulain , Bjorn Andersson , Kuogee Hsieh , Robert Foss , Vinod Koul , Rajesh Yadav , Jeykumar Sankaran , Neil Armstrong , Chandan Uddaraju Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , Archit Taneja , Sravanthi Kollukuduru References: <20230411-dpu-intf-te-v2-0-ef76c877eb97@somainline.org> <20230411-dpu-intf-te-v2-8-ef76c877eb97@somainline.org> From: Konrad Dybcio In-Reply-To: <20230411-dpu-intf-te-v2-8-ef76c877eb97@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 17.04.2023 22:21, Marijn Suijten wrote: > This callback was migrated from downstream when DPU1 was first > introduced to mainline, but never used by any component. Drop it to > save some lines and unnecessary confusion. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Marijn Suijten > --- Reviewed-by: Konrad Dybcio Konrad > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 18 ------------------ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 6 ------ > 2 files changed, 24 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c > index 0fcad9760b6f..b18efd640abd 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c > @@ -144,23 +144,6 @@ static bool dpu_hw_pp_get_autorefresh_config(struct dpu_hw_pingpong *pp, > return !!((val & BIT(31)) >> 31); > } > > -static int dpu_hw_pp_poll_timeout_wr_ptr(struct dpu_hw_pingpong *pp, > - u32 timeout_us) > -{ > - struct dpu_hw_blk_reg_map *c; > - u32 val; > - int rc; > - > - if (!pp) > - return -EINVAL; > - > - c = &pp->hw; > - rc = readl_poll_timeout(c->blk_addr + PP_LINE_COUNT, > - val, (val & 0xffff) >= 1, 10, timeout_us); > - > - return rc; > -} > - > static int dpu_hw_pp_enable_te(struct dpu_hw_pingpong *pp, bool enable) > { > struct dpu_hw_blk_reg_map *c; > @@ -280,7 +263,6 @@ static void _setup_pingpong_ops(struct dpu_hw_pingpong *c, > c->ops.get_vsync_info = dpu_hw_pp_get_vsync_info; > c->ops.setup_autorefresh = dpu_hw_pp_setup_autorefresh_config; > c->ops.get_autorefresh = dpu_hw_pp_get_autorefresh_config; > - c->ops.poll_timeout_wr_ptr = dpu_hw_pp_poll_timeout_wr_ptr; > c->ops.get_line_count = dpu_hw_pp_get_line_count; > c->ops.setup_dsc = dpu_hw_pp_setup_dsc; > c->ops.enable_dsc = dpu_hw_pp_dsc_enable; > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h > index c00223441d99..cf94b4ab603b 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h > @@ -107,12 +107,6 @@ struct dpu_hw_pingpong_ops { > bool (*get_autorefresh)(struct dpu_hw_pingpong *pp, > u32 *frame_count); > > - /** > - * poll until write pointer transmission starts > - * @Return: 0 on success, -ETIMEDOUT on timeout > - */ > - int (*poll_timeout_wr_ptr)(struct dpu_hw_pingpong *pp, u32 timeout_us); > - > /** > * Obtain current vertical line counter > */ >