From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 851ACC43219 for ; Tue, 12 Apr 2022 06:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236613AbiDLG5H (ORCPT ); Tue, 12 Apr 2022 02:57:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351772AbiDLGyW (ORCPT ); Tue, 12 Apr 2022 02:54:22 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42FDFBD3 for ; Mon, 11 Apr 2022 23:44:02 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id bv19so12278144ejb.6 for ; Mon, 11 Apr 2022 23:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gdMXT9TzsyH4/nxmkBNQPgpVjR8VBr666pmrMpmTXZI=; b=Sf9531F6U+Pwb0a1JtSz+UJf/7y7GtDmQlZZhYfSi+mfIvdBuA4l0w7/WatdjA9Ad6 TvV1/c+RE7sUGKS1/vUuU2MhBpzDMSR5e27v5CWt4Y1uEERO4rzy1WFE7UFOUTkys8y4 CrAZELDcitDaBEG070MG6AnwITJStO2p0wpebyOBC/F8c4E4tcDxGW0/DG5QxVW1sIpV 8p0pgBHVk3S74bwGfrfbc9v6owVXngqPs+TyhlqZ2FJ8kqVHCNvX0K4QrJKpDWlQQ4ZP fgucKqXTCFSYrEFgMqiDfOIFe4mCpdCXVpFSuD1BRgEDhCuvS5dXmNhhvfMGmg+v/lcO ESgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gdMXT9TzsyH4/nxmkBNQPgpVjR8VBr666pmrMpmTXZI=; b=l0aiTH0AUD/deMHhL5IJTKwcKibSQUQs4Xs9Ot9hoMFEiTNdzh/YgoOJg8Y9avXPGN mQ+H0fclzWlAR71loekRYw6NII2tO08BIZMa0KWchD37/kcwTEt558zGoEpgbtmbAyxu J2ScI+iaY1NlAytBEy+loRzLbHDEGt34n7oTZkfjplZZ+s2zEA704b6YTYZ7OKLO8Xo9 iSzLD9iimls/RYKNIBlTz1v7FuforFAXYzesuFfJ87oXiJ28faNeh2ss4wTl5Tlq8gBe JsFb28VbAyJSBW3sGJmhhJ962HN0hiF67VxFOEiGK6mGsgnTsWIEtfoyaGAvkG2Cb7JZ vVHQ== X-Gm-Message-State: AOAM530Hx9iOby8NfR5MZm7EeS0FUr1ySvRsBTfVL+oPFbX3T6LyE4Lf Z64W6Z5Yk+T3TwKUn6EpsUUcqA== X-Google-Smtp-Source: ABdhPJzlMIXt07hedFNdXekcNnAvfM3k0nzYSnt57hMcEFauFmO4UC80WvnBdB/kePIRmAW6KtUX+g== X-Received: by 2002:a17:907:1b06:b0:6e7:f58a:9b91 with SMTP id mp6-20020a1709071b0600b006e7f58a9b91mr34377224ejc.291.1649745840798; Mon, 11 Apr 2022 23:44:00 -0700 (PDT) Received: from [192.168.0.193] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id c1-20020a50cf01000000b0041cb7e02a5csm14566517edk.87.2022.04.11.23.43.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 23:44:00 -0700 (PDT) Message-ID: <8ff07720-3c52-99e6-8046-501f4ae28518@linaro.org> Date: Tue, 12 Apr 2022 08:43:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 6/6] dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format Content-Language: en-US To: Kuldeep Singh , Srinivas Kandagatla Cc: Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Vinod Koul , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org References: <20220410175056.79330-1-singh.kuldeep87k@gmail.com> <20220410175056.79330-7-singh.kuldeep87k@gmail.com> <14ecb746-56f0-2d3b-2f93-1af9407de4b7@linaro.org> <20220411105810.GB33220@9a2d8922b8f1> <50defa36-3d91-80ea-e303-abaade1c1f7e@linaro.org> <20220412061953.GA95928@9a2d8922b8f1> From: Krzysztof Kozlowski In-Reply-To: <20220412061953.GA95928@9a2d8922b8f1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 12/04/2022 08:19, Kuldeep Singh wrote: > On Mon, Apr 11, 2022 at 01:38:41PM +0200, Krzysztof Kozlowski wrote: >> On 11/04/2022 12:58, Kuldeep Singh wrote: >>>> This is something new and it seems only one SoC defines it (not even one >>>> BAM version). I wonder whether this is actually correct or this >>>> particular version of BAM is slightly different. Maybe someone could >>>> clarify it, but if no - looks ok. >>> >>> Yes, sdm845.dtsi uses 4 entries and rest 1. >> >> Yes, I know. This does not solve my wonder. >> >>> >>>> >>>>> + >>>>> + num-channels: >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>> + description: >>>>> + Indicates supported number of DMA channels in a remotely controlled bam. >>>>> + >>>>> + qcom,controlled-remotely: >>>>> + $ref: /schemas/types.yaml#/definitions/flag >>>> >>>> type: boolean >>> >>> Boolean comes under flag in types.yaml >>> >>> definitions: >>> flag: >>> oneOf: >>> - type: boolean >>> const: true >>> - type: 'null' >>> >>> I have seen other boolean properties(spi-cpol, spi-cpha and bunch of >>> others) using type flag. I think we should keep flag here. >> >> type:boolean is just shorter and example-schema recommends it. If you >> want to base on something (as a template, pattern) then the >> example-schema is the source, the preferred one. > > I had seen other spec using flag and that's why kept same here. I understand, you mentioned it before. However other spec is not the example-schema... > Which example schema are you talking about? There is only one example-schema. $ find ./linux -name 'example-schema*' >>>> clocks, clock-names, qcom-ee - these are required according to old bindings. >>> >>> I missed qcom,ee. Will add in v3. >>> >>> For clocks and clock-names , there are two platforms(msm8996.dtsi, >>> sdm845.dtsi) where these properties are missing. And I don't want to add >>> some random values. Shall I skip them here? and let board owners add >>> them later. >> >> These are required, so the SoC DTSI should be fixed. Not with random >> clocks but something proper. :) > > Yes absolutely :-) > I have kept Srinivas in copy, who sent initial support for both the > dtsi. Probably he can confirm provided his email doesn't bounce. > > Anyway Krzysztof, can you confirm the same as you have been actively > contributing to Qcom peripherals. I will add credit in follow-up > submission. Honestly not now, because I don't have access to related datasheets (I am working on this). You can though try to look at original (vendor) sources: https://git.codelinaro.org/clo/la/kernel/msm-4.19 (sdm845) https://git.codelinaro.org/clo/la/kernel/msm-3.18 (msm8996) Best regards, Krzysztof