From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] Revert "arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node"
Date: Tue, 30 Jan 2024 15:27:35 +0100 [thread overview]
Message-ID: <9016fa2b-fdd6-4124-a53b-e06d45acd673@linaro.org> (raw)
In-Reply-To: <20240130130930.18683-1-brgl@bgdev.pl>
On 30/01/2024 14:09, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This reverts commit 71a73864e144aadaa582fe8296ef73fcf3ea7377.
>
> The bluetooth module of the QCA6391 should be represented as consuming
> the power outputs of the PMU and not the regulators that are PMU's
> inputs. We will be able to model it this way (together with the WLAN
> module) once the pwrseq subsystem gets upstream with a dedicated driver
> for the PMU.
>
> Thankfully this change has no corresponding DT bindings yet so we can
> safely revert adding the bluetooth node.
>
> Fixes: 71a73864e144 ("arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node")
I don't think that dropping more-or-less correct DTS nodes is a fix. A
fix could be changing the less-correct DTS into fully-correct DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-30 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 13:09 [PATCH] Revert "arm64: dts: qcom: qrb5165-rb5: add the Bluetooth node" Bartosz Golaszewski
2024-01-30 14:27 ` Krzysztof Kozlowski [this message]
2024-01-30 15:12 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9016fa2b-fdd6-4124-a53b-e06d45acd673@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox