From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com,
bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, akapatra@quicinc.com,
hariramp@quicinc.com, andersson@kernel.org,
konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@quicinc.com
Subject: Re: [PATCH v1 1/2] media: dt-bindings: update clocks for sc7280-camss
Date: Tue, 21 Jan 2025 17:05:01 +0100 [thread overview]
Message-ID: <901ede5f-c5a1-42c4-ad87-b02e3ab332e4@kernel.org> (raw)
In-Reply-To: <1f509ab0-dd4a-4a93-90df-292bd4e6989e@quicinc.com>
On 21/01/2025 17:02, Vikram Sharma wrote:
>
> On 1/21/2025 6:25 PM, Krzysztof Kozlowski wrote:
>> On 21/01/2025 13:09, Vikram Sharma wrote:
>>> This patch change clock names to make it consistent with
>>
>> Please do not use "This commit/patch/change", but imperative mood. See
>> longer explanation here:
>> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> Hi Krzysztof,
> Thanks for your response.
> Will update commit text.
>>> existing platforms as gcc_cam_hf_axi -> gcc_axi_hf.
>> Which ones? sm8250 uses different.
> qcom,sc8280xp-camss.yaml uses 'gcc_axi_hf'
Then mention with which binding you align it.
>>
>>> This also adds gcc_axi_sf and remove gcc_camera_ahb.
>> Why?
>
> 'gcc_camera_ahb' is always 'on' and we don't need to enable it explicitly.
> 'gcc_axi_sf' basic use case works even without this clock but our 'Hardware programing guide' suggest to enable this one too to avoid unexpected behaviors.
> Konrad pointed these points in V8 of the series.
That's what the commit msg is for.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-21 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 12:08 [PATCH v1 0/2] Update clocks for sc7280-camss Vikram Sharma
2025-01-21 12:09 ` [PATCH v1 1/2] media: dt-bindings: update " Vikram Sharma
2025-01-21 12:55 ` Krzysztof Kozlowski
[not found] ` <1f509ab0-dd4a-4a93-90df-292bd4e6989e@quicinc.com>
2025-01-21 16:05 ` Krzysztof Kozlowski [this message]
2025-01-21 12:09 ` [PATCH v1 2/2] media: qcom: camss: update clock names for sc7280 Vikram Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=901ede5f-c5a1-42c4-ad87-b02e3ab332e4@kernel.org \
--to=krzk@kernel.org \
--cc=akapatra@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hariramp@quicinc.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vikramsa@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox