From: David Collins <quic_collinsd@quicinc.com>
To: Abel Vesa <abel.vesa@linaro.org>, Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Johan Hovold <johan@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v8 7/7] spmi: pmic-arb: Add multi bus support
Date: Fri, 5 Apr 2024 18:29:07 -0700 [thread overview]
Message-ID: <907632cd-ce3e-4868-92c8-8a79d09fa011@quicinc.com> (raw)
In-Reply-To: <20240402-spmi-multi-master-support-v8-7-ce6f2d14a058@linaro.org>
On 4/2/24 05:07, Abel Vesa wrote:
> +static void spmi_pmic_arb_deregister_buses(struct spmi_pmic_arb *pmic_arb)
> +{
> + int i;
> +
> + for (i = 0; i < PMIC_ARB_MAX_BUSES; i++) {
s/PMIC_ARB_MAX_BUSES/pmic_arb->buses_available/
This is needed to avoid a NULL pointer dereference in the case that a
single SPMI bus is specified in DT and then removed at runtime.
> + struct spmi_pmic_arb_bus *bus = pmic_arb->buses[i];
> +
> + irq_set_chained_handler_and_data(bus->irq,
> + NULL, NULL);
> + irq_domain_remove(bus->domain);
> + }
> +}
Thanks,
David Collins
prev parent reply other threads:[~2024-04-06 1:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 12:07 [PATCH v8 0/7] spmi: pmic-arb: Add support for multiple buses Abel Vesa
2024-04-02 12:07 ` [PATCH v8 1/7] dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema Abel Vesa
2024-04-06 1:28 ` David Collins
2024-04-02 12:07 ` [PATCH v8 2/7] dt-bindings: spmi: Deprecate qcom,bus-id Abel Vesa
2024-04-02 12:07 ` [PATCH v8 3/7] spmi: pmic-arb: Fix some compile warnings about members not being described Abel Vesa
2024-04-03 7:35 ` Neil Armstrong
2024-04-02 12:07 ` [PATCH v8 4/7] spmi: pmic-arb: Make the APID init a version operation Abel Vesa
2024-04-02 12:07 ` [PATCH v8 5/7] spmi: pmic-arb: Make core resources acquiring " Abel Vesa
2024-04-02 12:07 ` [PATCH v8 6/7] spmi: pmic-arb: Register controller for bus instead of arbiter Abel Vesa
2024-04-03 7:37 ` Neil Armstrong
2024-04-06 1:29 ` David Collins
2024-04-02 12:07 ` [PATCH v8 7/7] spmi: pmic-arb: Add multi bus support Abel Vesa
2024-04-03 7:37 ` Neil Armstrong
2024-04-06 1:29 ` David Collins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907632cd-ce3e-4868-92c8-8a79d09fa011@quicinc.com \
--to=quic_collinsd@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox