Re: [PATCH v3 1/2] dt-bindings: crypto: ice: Document sm8250 inline crypto engine

[Harshal Dev <harshal.dev@oss.qualcomm.com>]

On 3/11/2026 11:56 PM, Krzysztof Kozlowski wrote:
> On 10/03/2026 04:12, Alexander Koskovich wrote:
>> Document the compatible used for the inline crypto engine found on
>> SM8250.
>>
>> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
>> ---
>>  Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>> index 061ff718b23d..ccb74ea14ce8 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>> @@ -19,6 +19,7 @@ properties:
>>            - qcom,sa8775p-inline-crypto-engine
>>            - qcom,sc7180-inline-crypto-engine
>>            - qcom,sc7280-inline-crypto-engine
>> +          - qcom,sm8250-inline-crypto-engine
> 
> SM8250 does not need two clocks?
> 
> https://lore.kernel.org/r/20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com/

It does need the two clocks along with the power-domain. I can see they have been
added in the DTS but with the updated DT binding, I think they should also be made
'required' for sm8250 similar to Eliza and Milos.

https://lore.kernel.org/all/20260317-qcom_ice_power_and_clk_vote-v3-2-53371dbabd6a@oss.qualcomm.com/

Regards,
Harshal

> 
> Best regards,
> Krzysztof
>