From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dang Huynh <danct12@riseup.net>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button
Date: Mon, 29 Jul 2024 17:07:32 +0200 [thread overview]
Message-ID: <91004ef6-7904-412c-bc3b-28a50b704579@kernel.org> (raw)
In-Reply-To: <20240725-qx1050-feature-expansion-v2-1-5fac4bbd946f@riseup.net>
On 25/07/2024 03:42, Dang Huynh wrote:
> The Pro1X has a flip keyboard and a single-state camera button.
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 34 +++++++++++++++++++++++--
> 1 file changed, 32 insertions(+), 2 deletions(-)
>
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-29 15:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 1:42 [PATCH v2 00/11] F(x)tec Pro1X feature expansion Dang Huynh
2024-07-25 1:42 ` [PATCH v2 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button Dang Huynh
2024-07-29 12:03 ` Konrad Dybcio
2024-07-29 15:07 ` Krzysztof Kozlowski [this message]
2024-07-25 1:42 ` [PATCH v2 02/11] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander Dang Huynh
2024-07-25 1:42 ` [PATCH v2 03/11] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen Dang Huynh
2024-07-25 1:42 ` [PATCH v2 04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED Dang Huynh
2024-07-25 10:42 ` Konrad Dybcio
2024-07-25 1:42 ` [PATCH v2 05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot Dang Huynh
2024-07-25 10:42 ` Konrad Dybcio
2024-07-25 1:42 ` [PATCH v2 06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU Dang Huynh
2024-07-25 10:42 ` Konrad Dybcio
2024-07-25 1:42 ` [PATCH v2 07/11] arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS Dang Huynh
2024-07-25 1:42 ` [PATCH v2 08/11] arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property Dang Huynh
2024-07-25 1:42 ` [PATCH v2 09/11] arm64: dts: qcom: sm6115-pro1x: Enable RGB LED Dang Huynh
2024-07-25 1:42 ` [PATCH v2 10/11] arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs Dang Huynh
2024-07-25 1:42 ` [PATCH v2 11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN Dang Huynh
2024-07-25 10:41 ` Konrad Dybcio
2024-07-25 22:20 ` [PATCH v2 00/11] F(x)tec Pro1X feature expansion Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91004ef6-7904-412c-bc3b-28a50b704579@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danct12@riseup.net \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox