From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9EF1C43219 for ; Tue, 4 Oct 2022 08:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbiJDI7v (ORCPT ); Tue, 4 Oct 2022 04:59:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230155AbiJDI7t (ORCPT ); Tue, 4 Oct 2022 04:59:49 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64D0310068 for ; Tue, 4 Oct 2022 01:59:46 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id d6so6054856lfs.10 for ; Tue, 04 Oct 2022 01:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=IVn1e873PvRiD77ZTr/X3t/FlEWxpTUJ4sOFXDhbtHo=; b=XxwxkaXKiq6e5IwFsDFC6xGQP81S/9Ajpc0L8PX5Gnmowqj9rZOMrwu/hq04mOCc4P kbOMmzUBGi4KrbcJlfmHluVMZweqZk/4qBRKDXJYuYKCzdafknER/r7HP8wnBZY1rYox 4aVKLLV11n+eZrHcl2zpMinR5cLU52Xniyyxxe/NoeEBbrMTO3Q9TRWIDZqhNcS7oW6j cRYixH7NblTWcNYgJjMzFxfyA9XtEuPq9FoLWjp8YLZruJIDR6YootF78ri9wLPPrrNz vb5NSErH57CGJpWPHxNgu4+GKNJY91MK1XdoDPsZC2knrkjxezcXe3V9Qwh5xBiD0Qhm pbAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=IVn1e873PvRiD77ZTr/X3t/FlEWxpTUJ4sOFXDhbtHo=; b=dVpLMBJNqD7N6Q0nYXZkQ8wzzB8PxaPDVgOH/ykNEwc94cRpOGvyRxbN8qhPthpIw2 pz+jJHtRJgufE2ABC7Cjl8m9IDpSiJcH2hgrIejtMvW7IvaQM3GAwGe79dWscRt7vL1W QewEsMBnDtRVoBswFdXYY8ZBR9FLjFmktBtyTvGYvSqiSpmiMICortkKJS4BvKgJVRqK oHsdiKCW0or4U7exHrP8gsBi3TkZLRICs4ut/62eJjycFnTYee9KOcYSKYIeDIGzbHTA 8B7U/P9GFo1HAoX0L3KtyzC6L4kqhmwsNxG4wLHUZWSgKRbs+SUs+Ap+Xl6rUZBArYc9 8WmA== X-Gm-Message-State: ACrzQf38eS6g3HwcKNb4zeuhdjdMWLjo0ZQRtY1gUo6HDa7KxaUC2/WE PkOCyxq8pjcQRXpAlnMWf9Ua+7OgXjH/bw== X-Google-Smtp-Source: AMsMyM7iawg50cv/2c+1JUkuN8CbHjBOKFupbo7YU/iNfDEAxyF4uXalwVDZZbeEadjMENF9FKD2qA== X-Received: by 2002:a05:6512:308a:b0:4a2:eeb:a18c with SMTP id z10-20020a056512308a00b004a20eeba18cmr6682132lfd.255.1664873984765; Tue, 04 Oct 2022 01:59:44 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id y22-20020a197516000000b0048af4dc964asm1822327lfe.73.2022.10.04.01.59.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 01:59:44 -0700 (PDT) Message-ID: <91630a1c-c4bf-357f-20f3-8176bd91bdf6@linaro.org> Date: Tue, 4 Oct 2022 10:59:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Content-Language: en-US To: Neil Armstrong , Krzysztof Kozlowski , Bjorn Andersson , Satya Priya , Andy Gross , Alexandre Belloni , Rob Herring , Konrad Dybcio , Lee Jones , Dmitry Torokhov , Alessandro Zummo Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org References: <20220928-mdm9615-dt-schema-fixes-v2-0-87fbeb4ae053@linaro.org> <20220928-mdm9615-dt-schema-fixes-v2-6-87fbeb4ae053@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220928-mdm9615-dt-schema-fixes-v2-6-87fbeb4ae053@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 04/10/2022 10:08, Neil Armstrong wrote: > Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that > the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey. > > Signed-off-by: Neil Armstrong > You miss diffstat... but I guess it's result of b4? > diff --git a/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml > new file mode 100644 > index 000000000000..ae38c4ef4932 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/qcom,pm8921-pwrkey.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm PM8921 PMIC Power Key > + > +maintainers: > + - Andy Gross > + - Bjorn Andersson Keep only Bjorn. Andy did not review much for some time. > + > +allOf: > + - $ref: input.yaml# > + > +properties: > + compatible: > + oneOf: > + - enum: > + - qcom,pm8921-pwrkey > + - qcom,pm8058-pwrkey > + - items: > + - enum: > + - qcom,pm8018-pwrkey > + - const: qcom,pm8921-pwrkey > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 2 > + description: | > + The first interrupt specifies the key release interrupt > + and the second interrupt specifies the key press interrupt. In such case better to drop maxItems and description and write it: items: - description: key release interrupt - description: key press interrupt (maybe even the "interrupt" word could be skipped...) > + > + debounce: > + description: | > + Time in microseconds that key must be pressed or > + released for state change interrupt to trigger. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + pull-up: > + description: | > + Presence of this property indicates that the KPDPWR_N > + pin should be configured for pull up. > + $ref: /schemas/types.yaml#/definitions/flag > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + ssbi { > + #address-cells = <1>; > + #size-cells = <0>; Messed indentation. > + > + pmic@0 { > + reg = <0x0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + pwrkey@1c { > + compatible = "qcom,pm8921-pwrkey"; Messed up indentation. For entire DTS example keep 2 or 4 spaces. > + reg = <0x1c>; > + interrupt-parent = <&pmicint>; > + interrupts = <50 1>, <51 1>; Use defines for interrupt flags. > + debounce = <15625>; > + pull-up; > + }; > + }; > + }; Best regards, Krzysztof