From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Avri Altman <Avri.Altman@wdc.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>,
MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Evan Green <evgreen@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
Subhash Jadavani <subhashj@codeaurora.org>,
Bart Van Assche <bvanassche@acm.org>,
SCSI <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"
Date: Mon, 4 Feb 2019 13:23:49 -0700 [thread overview]
Message-ID: <91e7f06c-7d13-d0bd-efee-4a62a429f727@codeaurora.org> (raw)
In-Reply-To: <SN6PR04MB49255ADE41BBD35F894FD4CBFC6D0@SN6PR04MB4925.namprd04.prod.outlook.com>
On 2/4/2019 12:51 PM, Avri Altman wrote:
>
>> This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490.
>>
>> Calling ufshcd_set_vccq_rail_unused hangs my system.
>> It seems vccq is not *not* needed.
> This patch essentially implements the UFS_DEVICE_NO_VCCQ quirk,
> Which is needed for both Samsung and Hynix devices.
Needed, or optimal?
I'm rather sure Marc's device has a Samsung UFS chip, as do my devices
and we've seen nothing but benefit from the proposed revert.
> Once acked by those vendors, can be removed from the quirk list as well.
>
> Thanks,
> Avri
>>
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-02-04 20:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 17:34 [PATCH v3 0/5] UFS on APQ8098/MSM8998 Marc Gonzalez
2019-02-04 17:36 ` [PATCH v3 1/5] arm64: dts: qcom: msm8998: Add UFS nodes Marc Gonzalez
2019-02-04 18:06 ` Jeffrey Hugo
2019-02-06 10:58 ` Marc Gonzalez
2019-02-04 17:37 ` [PATCH v3 2/5] arm64: dts: qcom: msm8998: Allow drivers to set-load Marc Gonzalez
2019-02-04 18:06 ` Jeffrey Hugo
2019-02-04 17:38 ` [PATCH v3 3/5] dt-bindings: phy-qcom-qmp: Add qcom,msm8998-qmp-ufs-phy Marc Gonzalez
2019-02-04 18:08 ` Jeffrey Hugo
2019-02-04 17:39 ` [PATCH v3 4/5] phy: qcom-qmp: Add QMP UFS PHY support for msm8998 Marc Gonzalez
2019-02-04 18:10 ` Jeffrey Hugo
2019-02-06 12:39 ` Kishon Vijay Abraham I
2019-02-06 12:44 ` Marc Gonzalez
2019-02-04 17:42 ` [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device" Marc Gonzalez
2019-02-04 18:11 ` Jeffrey Hugo
2019-02-04 19:51 ` Avri Altman
2019-02-04 20:23 ` Jeffrey Hugo [this message]
2019-02-04 20:27 ` Bjorn Andersson
2019-02-05 4:58 ` Alim Akhtar
2019-02-05 6:27 ` Bjorn Andersson
2019-02-05 10:52 ` Alim Akhtar
2019-02-05 19:46 ` Bjorn Andersson
2019-02-06 15:23 ` Alim Akhtar
2019-02-05 17:24 ` Marc Gonzalez
2019-02-05 17:51 ` Marc Gonzalez
2019-02-05 18:19 ` Evan Green
2019-02-05 19:37 ` Jeffrey Hugo
2019-02-06 14:53 ` Marc Gonzalez
2019-02-06 14:59 ` Marc Gonzalez
2019-02-06 15:27 ` Alim Akhtar
2019-02-06 15:52 ` Marc Gonzalez
2019-02-07 8:50 ` Alim Akhtar
2019-02-07 14:52 ` Jeffrey Hugo
2019-02-08 9:09 ` Alim Akhtar
2019-02-08 10:03 ` Marc Gonzalez
2019-02-08 14:59 ` Jeffrey Hugo
2019-02-09 8:42 ` Alim Akhtar
2019-02-09 11:49 ` Marc Gonzalez
2019-02-10 15:58 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91e7f06c-7d13-d0bd-efee-4a62a429f727@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=bvanassche@acm.org \
--cc=david.brown@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=pedrom.sousa@synopsys.com \
--cc=subhashj@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).