From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey Hugo Subject: Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device" Date: Mon, 4 Feb 2019 13:23:49 -0700 Message-ID: <91e7f06c-7d13-d0bd-efee-4a62a429f727@codeaurora.org> References: <70618c25-83f0-b9db-51a3-c1d74b605a45@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Avri Altman , Marc Gonzalez , MSM , LKML Cc: Bjorn Andersson , Andy Gross , David Brown , Evan Green , Douglas Anderson , Alim Akhtar , Pedro Sousa , Subhash Jadavani , Bart Van Assche , SCSI List-Id: linux-arm-msm@vger.kernel.org On 2/4/2019 12:51 PM, Avri Altman wrote: > >> This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. >> >> Calling ufshcd_set_vccq_rail_unused hangs my system. >> It seems vccq is not *not* needed. > This patch essentially implements the UFS_DEVICE_NO_VCCQ quirk, > Which is needed for both Samsung and Hynix devices. Needed, or optimal? I'm rather sure Marc's device has a Samsung UFS chip, as do my devices and we've seen nothing but benefit from the proposed revert. > Once acked by those vendors, can be removed from the quirk list as well. > > Thanks, > Avri >> >> Signed-off-by: Marc Gonzalez -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.