From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CD1C433EF for ; Thu, 7 Jul 2022 21:35:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236730AbiGGVfP (ORCPT ); Thu, 7 Jul 2022 17:35:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236442AbiGGVfN (ORCPT ); Thu, 7 Jul 2022 17:35:13 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9687C380 for ; Thu, 7 Jul 2022 14:35:12 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id bf9so10076856lfb.13 for ; Thu, 07 Jul 2022 14:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=SD0NxvCJo32HYd+2WD+ONWSoll8afsUSYzd6YC6f2ac=; b=Yd0rw0t7ckAq+3RTm6AZOhVD5TIdiSyr2zkVbGg0YMmzpPjSBZrfpkkLZnKgXan7Pj dEsi8Jpkd1Bhm89Bfp+vTzdZiT2ydU3CAp6VVx64w//Eh2wWBQp3TKdtdYsbJUv1DgfI Uj0311zBVQEtAC0LBOoA+qJcL3woCe1W83n+ASzjW8Lct/UohtvCvqj29Gn+VCbymwff jHKwaTPdJ6M81cT9nFb36WAfYM/e4mqk7q22zULxugh8oqHHe1m+Xwf5N+J2E56JM8/W aY9yYy7zPXWEuStZfNAjd7PfGmXs0NE0AUpKMrE6qPPa1gr6MxPjFu6Kw472nk1jO7cH SgIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SD0NxvCJo32HYd+2WD+ONWSoll8afsUSYzd6YC6f2ac=; b=Pau4pkzbwOkiq3XE8Z5FusEkXQSFMM1+GUbo3RVhKLFpjwvpAGyQLw8Vpxlg947H3T Irqga92QiWbO0lEIuYT1yJ5ai+ZAOSpNZPHNnjofN4FHSLiBtZm3YarkU0J16g2ykUyP R6ZhXtYN13kAXIpuVajeW+CzHmCTzJYnSG5Y6YxfxLAlZIpk+lVRRTnKtiztq5yUcv+A SOuVxskHSflots5EsQUZnBqBrHolMzmaj9kjEy3LWnJOcJmKfJ0VSPpT1eSiN7ZUrnLh guubu7cCQO8wWEve07aC3C9rb1IoSqOOQWzpIRIOblzHM4LzRqemYoSRHppyWOJyNQjG n8WQ== X-Gm-Message-State: AJIora/gdR/MSY6ItXdwEPdfUgvLHx6qp3lm8KtpsphJWoiOwpnc6vn0 7h5GGJJTjIEO8GxxLrVrLeGJ5Q== X-Google-Smtp-Source: AGRyM1s01Ak2ESoCsiR0hzOAkFb6zGRLzecc9aB/OcMWeyDDvPq67Rf/HR/PYmmWNLqShfF28ejfig== X-Received: by 2002:a05:6512:2810:b0:47f:a76c:8770 with SMTP id cf16-20020a056512281000b0047fa76c8770mr182935lfb.116.1657229711019; Thu, 07 Jul 2022 14:35:11 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id u10-20020a05651220ca00b0048957b0c58fsm182205lfr.47.2022.07.07.14.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 14:35:10 -0700 (PDT) Message-ID: <92483e36-e0bc-3cdb-a9b9-fa354c948c19@linaro.org> Date: Fri, 8 Jul 2022 00:35:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] drm/msm/dpu: Fix for non-visible planes Content-Language: en-GB To: Rob Clark , dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Jessica Zhang , Fernando Ramos , Mark Yacoub , open list References: <20220707212003.1710163-1-robdclark@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20220707212003.1710163-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 08/07/2022 00:20, Rob Clark wrote: > From: Rob Clark > > Fixes `kms_cursor_crc --run-subtest cursor-offscreen`.. when the cursor > moves offscreen the plane becomes non-visible, so we need to skip over > it in crtc atomic test and mixer setup. > > Signed-off-by: Rob Clark Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index 4dd0ce09ca74..4ba000951a90 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -422,6 +422,9 @@ static void _dpu_crtc_blend_setup_mixer(struct drm_crtc *crtc, > if (!state) > continue; > > + if (!state->visible) > + continue; > + > pstate = to_dpu_plane_state(state); > fb = state->fb; > > @@ -1195,6 +1198,9 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc, > if (cnt >= DPU_STAGE_MAX * 4) > continue; > > + if (!pstate->visible) > + continue; > + > pstates[cnt].dpu_pstate = dpu_pstate; > pstates[cnt].drm_pstate = pstate; > pstates[cnt].stage = pstate->normalized_zpos; -- With best wishes Dmitry