RE: [PATCH/RFC V2 10/16] scsi: ufs: add UFS power management support

["Dolev Raviv" <draviv@codeaurora.org>]

Hi all,
Thanks for reviewing the patches, I'm sorry for the late replay. I was
waiting for some comments before I address all at once and re-send the
series.

>>
>> +static int ufshcd_config_vreg_load(struct device *dev, struct ufs_vreg
>> *vreg,
>> +				   int ua)
>> +{
>> +	int ret = 0;
>> +	struct regulator *reg = vreg->reg;
>> +	const char *name = vreg->name;
>> +
>> +	BUG_ON(!vreg);
>
> For the UFS host controller driver, which doesn't have the ufs_vreg
> structure for vcc and vccq, this function can cause kernel panic due to
> this BUG_ON(). Any reason to put a BUG_ON here instead of a NULL pointer
> checking?
>
> Thanks
> Chuanxiao
>

Sure, I'll fix this.

Thanks,
Dolev

> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation