From: Kathiravan T <kathirav@codeaurora.org>
To: Robert Marko <robimarko@gmail.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: ipq8074: disable USB phy by default
Date: Mon, 31 May 2021 17:42:08 +0530 [thread overview]
Message-ID: <92bd27423bbec56881c47eea6c382f42@codeaurora.org> (raw)
In-Reply-To: <20210526150125.1816335-1-robimarko@gmail.com>
On 2021-05-26 20:31, Robert Marko wrote:
> One of the QUSB USB PHY-s has been left enabled by
> default, this is probably just a mistake as other
> USB PHY-s are disabled by default.
>
> It makes no sense to have it enabled by default as
> not all board implement USB ports, so disable it.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
Always, it is better to disable in SOC DTS and enable only in the board
DTS files.
Reviewed-by: Kathiravan T <kathirav@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 555a107959831..20059d0f7d714 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -286,6 +286,7 @@ qusb_phy_0: phy@79000 {
> clock-names = "cfg_ahb", "ref";
>
> resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
> + status = "disabled";
> };
>
> qmp_pcie_phy0: phy@84000 {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2021-05-31 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 15:01 [PATCH] arm64: dts: ipq8074: disable USB phy by default Robert Marko
2021-05-31 12:12 ` Kathiravan T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92bd27423bbec56881c47eea6c382f42@codeaurora.org \
--to=kathirav@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).