From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F88DC4332F for ; Sat, 14 May 2022 19:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234906AbiENTcO (ORCPT ); Sat, 14 May 2022 15:32:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234037AbiENTcN (ORCPT ); Sat, 14 May 2022 15:32:13 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA7C31B7A3 for ; Sat, 14 May 2022 12:32:10 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id d15so19742149lfk.5 for ; Sat, 14 May 2022 12:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fXzV1fpic6FIBZFtsxUjhfRXDG+va5qpRFfngHIik8E=; b=WMwBL9u+A7cVFaSFpoSvfQhotjddSY3EEfSStc/go3iWLy7T4NqDaod58gnHU1T6tR wCYfEEHhQ5L1xTZcF8uiyLWh2mJET+ibN/8dtyMkATHs1Y+W/rIhs+qVls6IG+J1Qnyf 0wRGdwZhCF3ZFyfePovHpgZYVssiFt1X4SnGLnQkPv6o9t+0fWEUzT05nVparICioHLg FWsIDfC7Ta3IiKHQS81GQyErMdey8NdrKvgB3l4VDgqAS8V9XoOSMI7dCIbBcuRMHP0V OkWnBgClT2qMSjiFN4LPWsNPbZAiwo+XJJ6Qd2muplhM2Mqi3MCQECnKH13Cx5WN6Ib6 PQkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fXzV1fpic6FIBZFtsxUjhfRXDG+va5qpRFfngHIik8E=; b=2TZcPDsZMrDFRJBmtuRnPXbxmYpob257ukAMAnIYMop9N8jeuisXrWfiwSIO5SqDgw JyXn0dJ6xRuAvd8PXSCECscNfBOV7PTb0oSzpcTLn5S0JfwZWTjJy7lUeh/K7PW6AIFO y5VqqFt4L5E/wx+u4DQaKMlrBQnmm75oMlJe4qHK5gov29pLadPmWLhEKnybsAO7FSaj AREpWWztxJmRFo9fiIweiyFoZQchPVAUHz9UPYFrms/BEbClV51NpoU0/6fEVs6iqOs4 0b7Z9TmagLk7HqasDYepW9RcO39cukaL1RjgBto/EaDuafmBpnxtmJAUPDMwlm95nFS1 Ukcg== X-Gm-Message-State: AOAM533RztdL5/en0dTsd+jRfFigxRW98IQkwBzlCnCDpw+Y9NG37Q8V OY/4n/iRxY7p2uk7fZMrv8xEuQ== X-Google-Smtp-Source: ABdhPJwe5i88awrmyIJNqgBJD6YgpXCrsim3T+efhyaQX+lVYDbU3HXxwumOjap7znAZcwsvxAG5iA== X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr7745769lfa.499.1652556729330; Sat, 14 May 2022 12:32:09 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id f13-20020a2eb5ad000000b0024f3d1daedfsm896630ljn.103.2022.05.14.12.32.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 May 2022 12:32:08 -0700 (PDT) Message-ID: <93181c1d-16a7-697e-976c-190b1c99f2c2@linaro.org> Date: Sat, 14 May 2022 21:32:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] ath10k: do not enforce interrupt trigger type Content-Language: en-US To: Kalle Valo Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Govind Singh , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , linux-arm-msm@vger.kernel.org References: <20220513151516.357549-1-krzysztof.kozlowski@linaro.org> <87zgjl4e8t.fsf@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <87zgjl4e8t.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 13/05/2022 17:57, Kalle Valo wrote: > Krzysztof Kozlowski writes: > >> Interrupt line can be configured on different hardware in different way, >> even inverted. Therefore driver should not enforce specific trigger >> type - edge rising - but instead rely on Devicetree to configure it. >> >> All Qualcomm DTSI with WCN3990 define the interrupt type as level high, >> so the mismatch between DTSI and driver causes rebind issues: >> >> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/unbind >> $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/bind >> [ 44.763114] irq: type mismatch, failed to map hwirq-446 for interrupt-controller@17a00000! >> [ 44.763130] ath10k_snoc 18800000.wifi: error -ENXIO: IRQ index 0 not found >> [ 44.763140] ath10k_snoc 18800000.wifi: failed to initialize resource: -6 > > So you tested on WCN3990? On what firmware version? I run it on a Qualcomm RB3 board with Qualcomm SDM845 and WCN3990. However on that kernel I did not manage to WiFi actually work - regardless of that patch - so I would no count it yet as fully tested. It would be great if someone would provide some tests. I saw Steev's replies - thanks! Best regards, Krzysztof