From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9F933290C7; Fri, 27 Feb 2026 07:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772177072; cv=none; b=BMlRsDYKYStuQEbEwVf6BXUSU4SseM6zg8VnykMYJbCS+xKTRL66T6hd04U4GnMakvbc6He8Xu6fLOM6zwr+s3TsJvtgO9zwFnjQETgmLz3RAen/EkpKVX7pQ9Rbl3+shTFpOAumoPAQi1TZHOVZYqhtyIKJybV7OQktdvLnGOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772177072; c=relaxed/simple; bh=GFsoVjf6iZGZ1skfc8tFzdLVvpfXut00+vtgnIytMP8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tDs3/i7uyTYc3cdmlDMlJDGxKZ9EkwyNms8DxPlrVc/E6mqvL6WDJH+9teTdIaerE6IEpn6AGYbv3gsLxAtYVIXZB4MJ1sIJcj69WglHiPyHCLkFeBwtNWF5zQjx6XoRkk7zeqXx0tqXRerz9rB3Z76iSHjv1IA6kE7mimi3T1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EpqVnoRo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EpqVnoRo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D86FEC116C6; Fri, 27 Feb 2026 07:24:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772177072; bh=GFsoVjf6iZGZ1skfc8tFzdLVvpfXut00+vtgnIytMP8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EpqVnoRoIEkasvj+HEAPOl1tpYKV1PAm2XL/d6bfj5ihTXmGC1Vew8kQ6k3GQmxoI mvSmhyW8fs3qS4RMgn8B+/l+E0JbLGowW4WGaVk5WaOU54/UiILiEzC5PikR6z8n9a VVSNTqnaUEre9DhgmnLbZBDZfsKxRdvg94YEgHsIKKR9EAz0yNy+rBMdpEU9YL4oCA VIPLdDB3n9UCudUl+IMN3B/QV5GQEDOtHWkxxeV5DtljzsGNPwxJ5+Lk81xvL7BbgU YxGes2e30WfKWTLy1Fbvt78Tycv/vMBZKaQUi2YB1BAOlXm3Fp2E3ciuJCh2L5BQeh 3ztzf0vAJEZQA== Message-ID: <934812b1-a853-471f-beb7-3988eff0856d@kernel.org> Date: Fri, 27 Feb 2026 08:24:27 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 02/18] dt-bindings: media: qcom,x1e80100-camss: Convert from inline PHY definitions to PHY handles To: Bryan O'Donoghue , Bryan O'Donoghue Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-0-95517393bcb2@linaro.org> <20260225-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v8-2-95517393bcb2@linaro.org> <20260226-fluffy-complex-malamute-7ecec6@quoll> <35b1ba2a-e156-4542-b33a-d4e53f6a62cb@kernel.org> <4ebe2f26-29fa-4104-bc90-3f5aa7009ec3@kernel.org> <72f0ed74-ac86-4571-8a72-d41282349718@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/02/2026 11:06, Bryan O'Donoghue wrote: > On 26/02/2026 09:50, Krzysztof Kozlowski wrote: >> On 26/02/2026 10:40, Bryan O'Donoghue wrote: >>> On 26/02/2026 09:33, Krzysztof Kozlowski wrote: >>>> On 26/02/2026 10:27, Bryan O'Donoghue wrote: >>>>> On 26/02/2026 07:07, Krzysztof Kozlowski wrote: >>>>>> No, it does not allow that. You cannto change the ABI. >>>>>> >>>>>> That's why I reminded multiple times before reviewing new CAMSS bindings >>>>>> for Milos and something more. Because once it gets accepted, you cannot >>>>>> change it anymore without valid reason. And there is no valid reason >>>>>> here provided. I kept these patches in staging/waiting for long >>>>>> enough... >>>>> >>>>> I thought your policy was - a dtsi had to have it, which we don't yet have. >>>> >>>> And from where did you take that policy? I am pretty sure my each >>>> comment is about ABI. Heh, I even commented few times about implied ABI >>>> purely based on kernel, without DTS. >>> >>> Correct me if I'm wrong. I thought we had discussed either @ the Linaro >>> Dublin meet or the Linaro Amsterdam meet that changing upstream YAML >>> would be feasible _if_ you could show there was no dependency on it - >>> say u-boot, FreeBSD etc. >> >> And I mentioned multiple caveats and restrictions. Do you quote them >> here or just took the first part of sentence before ", but only ..."? >> >> Anyway, whatever spoken is improvable and I am sure I did not give such >> permissions, maybe except that Dublin meeting was in 2024 thus before >> the release of previous user, so before v6.16, so of course you can >> still reshape unreleased ABI. And then you released it closing the >> discussion. > Well, is there a way to support both then ? I would just not touch x1e80100, but if you want then probably binding should stay backwards compatible, where you keep all properties intact and only add csiphy nodes. > > Right now I have csiphy and their registers listed in the camss block. > > I could add phys = <> as optional in the schema. Is there any reason to > stop adding adjacent csiphy nodes ? I think no. > > isp@addr { > regs = 0xCSID0, > 0xCSIPH1; > reg-names = "csidX", > "csiphy0"; > }; > > csiphy@CSIPHY1 {} > > I'm not sure if this is against DT rules. > > The iommu items _should_ be fine as its maxItems so I can just set that > to five instead of eight in the dtsi. > > --- > bod Best regards, Krzysztof