From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC6F33E025D for ; Tue, 24 Mar 2026 13:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774357813; cv=none; b=nPhNWRJzdNSN5u+WtOKlz5LD4ljjyvaZ1FgtPQ3jEpQI8tueLagoY8tYjOlBx7KYcKdpm5cUzyp6wwldXBVp0CwAfHUnlQ1t/sfTdaEmhBJYbfceZectQg3PvpXA5oYqf/Hb7MpGatItem+cc5+XNBCrSkanf+IWutd9MvrvcxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774357813; c=relaxed/simple; bh=XjjoBCqsPWoUyiJTSUCrVAmiqVUuemEKFjvvw3QmQ7Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TLFpiHj5n+acq0wsS+bEZlY/4GhSPs6AFneEzXguH5CcovL0oL0LUL7gqdznQBS81HZFT1eD+vgxWFCSuQDq3Rj7kgk/OywDQazvhTUdJsPMT8oiIIloeru4vD4Xrn8jW9xV2srKUAwvmJhdpOYYBCtEbjnbDrtu7mJ0d/9E5Uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jw1XReow; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E/xn/u1p; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jw1XReow"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E/xn/u1p" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62OA7ihp1761789 for ; Tue, 24 Mar 2026 13:10:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7tmu0SBYVZeN4wXo5FDEvB7ZxNsjgyVdo+2SDD6LM7I=; b=jw1XReowrlDAzqM5 vdUM7VNbdTTNW1CDWT2toKrapa59pPeZUSIhI7S1je/+PsUOWWLdzJDfA1zXYaD/ 7sYe5dH4/Ly+/hrQYAwI/9IMeNpxJ5Mp6IRPlrupH1ZcsQIZ9fYI9OLUzRtLUZRG W36EzTmeC4h8jiDhlqsjYJa8sDNQ2rmXZWdnlWlF2kPHGGJW+gG5ctSAUgUSjNNI 9fXn9Uw7z1UQeMAVeFKO9qX3gmlervnJvAOLR7DfmfukFhDG92rSgxr5/WwtWIke o7rndhkPzS60BDrRfflNHCo7UR52KU6pKWVf4cFFtDifsdKK31lJLduxDJ+zZp+I LYxBrA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d36f0ckqh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 13:10:10 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b2cbe7223so76999781cf.2 for ; Tue, 24 Mar 2026 06:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774357810; x=1774962610; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7tmu0SBYVZeN4wXo5FDEvB7ZxNsjgyVdo+2SDD6LM7I=; b=E/xn/u1pMzuAifYFHM5q1zdsEhv06VXcfqCm1Hz63rx81sAVHw6K+Bambkoy1yE+VT NJr5gOUuDaN7KFNeKgUBybQRM4xjCzNGYR/s0ykkbO6/TV/HoDUPbQpVjb+iwIuMQyiY sZME7ipCumd4cW0JScHyq6bZ0wf29hK1Q9hYLWMNk7r4iDYjbaRjFrYey5KL1ZjQn5D0 BmtOwYhsry06h5G2kZLcMRu8iFHl68VRpXhqYBWZnbkLpV7Vdvdhc4pHI5ly695bAXz5 wwe+eKnpmArmOIMXbvpqyw8Vms/fL3RUyH1AjN/vkq5qNQcROI48tRBt616RedNpXz04 cD6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774357810; x=1774962610; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7tmu0SBYVZeN4wXo5FDEvB7ZxNsjgyVdo+2SDD6LM7I=; b=KHHLJIj3HkLHpa/S55XLSk+RLMbhwKbIoMV4ffn43ju0sY9u9QCFrV4vID0vgi1lG7 +fqMs3Oe+xktS7+7/mjDJPlxB79CvpVxYVRCxxRwTo0LllsknI7AMMXddgG0v2lzt92g Y9XiYZSrS48I5jEAP2gdcXHdntiGfrf60ME9HDj21Nq0YR3WMzaQclNIao1Dz1x+DJGF A2iEP6iQVatW/37q6WcriSY/L4wPlb2wEJHwD9/7P+GpXuMp4kRYvpQoVX7AmNTUaFVG GkRZn48LI8ybEm0VYDOBycrbv6d+7EUoWppqXVqwyUyrzz3hmHM9bzScIe6qmNAnqDxn 5JUg== X-Forwarded-Encrypted: i=1; AJvYcCX6D9yCQMGIDbSuRN/oGZWMyOBi2u4Z8LjldSn/R80gGjhyHanlGdLOTwfqZ5z3HHs6eIbWUX1m9nn7lHPo@vger.kernel.org X-Gm-Message-State: AOJu0YzVi0B79sUYmY6fo7igX/3rn9B4h/5xzXh3naeyPjXXmFADrfXX +TTjdODCGwRwuCmAoxBqL1zge0OqV8vrkM/s+NwUZCEPoaecsAfJkLlSy6yqpyRj8KOeXEAb1o6 8cvUrp0gdURkcr4DYQq/osrrLn/3EMKtaw/YQ1EeSFi0EA7SbdOfFT6bP/RHco2t2xvFf X-Gm-Gg: ATEYQzxW2oXeRrDfKQ2MCszNiERmASj4f0Xc677j2vN9Y+NUek9TTUJZ4U5FN4PHARw rwrzMWW8NoayZQsDHkESq4zICUfsD2zrkhU+Ri7Fo9GyeVCfuDNLQWOv66h2wek5fTfC/Pf+JWv /cxM2b6IwYP/dS20qW5KPTcddirZGaCWzG7YdqseZbFw+8ph0tDnaVTZmH4OfSqWE0ONT6VDJsW Gz/nk1ZR5Va0Zf/+3F2fbIJNOB3ZMo4Aj+QEzZzd4a1/hbZo5jFhI3llrJof67O9XTSsUCRNd27 rrUHottRdrPJDokRSpRCFqkKRn5P7m5ohA3lTdY5iQE2o2X2LRT7QcCHAgHGTMaJrMMHrpeO8CV PGojVc4UBLRUB1aQNNEKJgEetTPwFrGKmAQOa2JGsSTqpjeQlHf/9nKqVLVGhUdDjjhbNxfHua3 C47yXY3sA= X-Received: by 2002:ac8:5d4d:0:b0:509:1b01:8926 with SMTP id d75a77b69052e-50b3738b0eemr254227331cf.6.1774357809991; Tue, 24 Mar 2026 06:10:09 -0700 (PDT) X-Received: by 2002:ac8:5d4d:0:b0:509:1b01:8926 with SMTP id d75a77b69052e-50b3738b0eemr254226801cf.6.1774357809508; Tue, 24 Mar 2026 06:10:09 -0700 (PDT) Received: from [10.38.244.11] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50b36e5cc1fsm110775811cf.22.2026.03.24.06.10.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 06:10:08 -0700 (PDT) Message-ID: <93624dae-71c0-45ac-9aca-7175d8771a32@oss.qualcomm.com> Date: Tue, 24 Mar 2026 21:10:01 +0800 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite To: Loic Poulain Cc: Robert Foss , Todor Tomov , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Hans Verkuil , Gjorgji Rosikopulos , Radoslav Tsvetkov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260319-camss_fix-v1-1-e69a3590500e@oss.qualcomm.com> <02ecbd98-01dc-4e56-901b-41783c55d095@oss.qualcomm.com> Content-Language: en-US From: Wenmeng Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=b+q/I9Gx c=1 sm=1 tr=0 ts=69c28d32 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=geiQnwYwG4LExPUYDA8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: n5r2xtCdle7KdhG9Fi-iS7ie_YYjohoG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDEwNCBTYWx0ZWRfX4gKNE9FDkrNj 0GVi8nkfYP7GTsn4F6x26RQpvk7Pl1GVWD26L4btna8JgQENliKLiEfMg6VSk/YMRoYq6XY/07I jQrOyexTRfqrzlFfotK/deSL5Vly6y76K8l+2Gxw73CzxXridN9+YNC6qU1hKYsVRIkLLKQif7X kE2g14apzbBb5nKX7KfuJiAWyC8GuDJDUsxQlI4aKTmr2q8sQuCNanvSvG/AYAMFS5ppUDCe6nO Av3X22X4aNulYlzl3QCJ7o84TN9gp3i0HlAhi1rkPh16UdzoDc3SO4So4E6hVHSqT4jWWP47a+m +Pr9XnXAiBKNc6cK7zqqvO7zzEoiTw0bT6BtrFjP43a4R1//d4JImpTFnJk0YceVTpO06gCBUOJ Q+8k3vafJdScai7NzXVx5OT8Kj0UaXqzbbkmoRrsT5yoRpM/d3rHL4X6boQK/E10jlG1cf8o4h5 JDiwnqxGHoYaGzI0RdA== X-Proofpoint-GUID: n5r2xtCdle7KdhG9Fi-iS7ie_YYjohoG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_03,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240104 On 3/23/2026 5:55 PM, Loic Poulain wrote: > On Mon, Mar 23, 2026 at 3:13 AM Wenmeng Liu > wrote: >> >> >> >> On 3/19/2026 10:44 PM, Loic Poulain wrote: >>> On Thu, Mar 19, 2026 at 10:11 AM Wenmeng Liu >>> wrote: >>>> >>>> VFE lite hardware does not provide a functional PIX path, but after >>>> the per sub-device type resource changes the PIX subdev name is still >>>> assigned unconditionally. >>>> >>>> Only assign the PIX subdev name on non-lite VFE variants to avoid >>>> exposing a misleading device name. >>>> >>>> Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources") >>>> Signed-off-by: Wenmeng Liu >>>> --- >>>> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c >>>> index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644 >>>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c >>>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c >>>> @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe, >>>> v4l2_subdev_init(sd, &vfe_v4l2_ops); >>>> sd->internal_ops = &vfe_v4l2_internal_ops; >>>> sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; >>>> - if (i == VFE_LINE_PIX) >>>> + if (i == VFE_LINE_PIX && vfe->res->is_lite == false) >>>> snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s", >>>> MSM_VFE_NAME, vfe->id, "pix"); >>> >>> So the PIX path will be called RDI? Doesn’t that seem misleading as well? >> when i == VFE_LINE_PIX and vfe->res->is_lite == false then vfe name is >> pix, not rdi. > > I mean when is_lite==true, we're going to name the PIX(lite) path RDI, > whereas it's not a raw dump interface, I guess pix-lite includes minimal > processing engine. For VFE Lite, only RDI paths are supported. There is no PIX output. Thanks, Wenmeng