From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 632B8C7EE2A for ; Sun, 21 May 2023 16:13:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229569AbjEUQNG (ORCPT ); Sun, 21 May 2023 12:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjEUQNF (ORCPT ); Sun, 21 May 2023 12:13:05 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D03CA0; Sun, 21 May 2023 09:13:04 -0700 (PDT) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34LG02cF030077; Sun, 21 May 2023 16:13:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=YYnUFLAC41egRRFfI/rmxuynlQqJkc9OwBnpIn7ivis=; b=lRFnYX6MCED0s8OQfs07xW/k6hllA1gM3tUn7TtZ6PsV49mHci2X+0eE7N3SDKGvhUNZ 556CzHf/tmQv20+mPWhuXnDytWq7NndPJUQHyxI/KhgPD9e//TV9ThOdfX475hViB2gQ FR07btYpv38J10CrpxluvgdQAFOk45oOigXwWO8cbZLjPXAWh20pGcLE4J8yVkkRC2CL ydLZcS6BgJYJ569mKPISk37lhmDFNDO9ByOe1aAETxF90mAfi9xiMMzZJZ714E0yzwst SakioihHXWRfcH+2MMj70fFjfZvUfWjRNV9GJy+SDkl18KwfMRQYBlGKJb2uVxJVUurm rg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qpqctsvqk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 21 May 2023 16:12:59 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34LGCxL6021064 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 21 May 2023 16:12:59 GMT Received: from [10.216.45.27] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Sun, 21 May 2023 09:12:50 -0700 Message-ID: <9368fb33-9718-a2a0-4c3c-ca3f568bf484@quicinc.com> Date: Sun, 21 May 2023 21:42:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 10/11] arm64: dts: qcom: ipq5018: Add MP03.5-c1 board support Content-Language: en-US To: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , CC: , , , , , , References: <1678164097-13247-1-git-send-email-quic_mmanikan@quicinc.com> <1678164097-13247-11-git-send-email-quic_mmanikan@quicinc.com> <69fdc094-aa1e-a696-1f62-e9287451976d@linaro.org> From: Manikanta Mylavarapu In-Reply-To: <69fdc094-aa1e-a696-1f62-e9287451976d@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: -a4AtVqba3fXTDIF6xCP_EhCfEMOis-U X-Proofpoint-GUID: -a4AtVqba3fXTDIF6xCP_EhCfEMOis-U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-21_12,2023-05-17_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 phishscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305210143 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/7/2023 9:12 PM, Krzysztof Kozlowski wrote: > On 07/03/2023 05:41, Manikanta Mylavarapu wrote: >> Add initial device tree support for the MP03.5-C1 board. >> >> Signed-off-by: Manikanta Mylavarapu >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> .../arm64/boot/dts/qcom/ipq5018-mp03.5-c1.dts | 64 +++++++++++++++++++ >> 2 files changed, 65 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-mp03.5-c1.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index b77a95e97a56..10d1eafe57e4 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb >> dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb >> dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb >> dtb-$(CONFIG_ARCH_QCOM) += ipq5018-mp03.1-c2.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += ipq5018-mp03.5-c1.dtb >> dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb >> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb >> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb >> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-mp03.5-c1.dts b/arch/arm64/boot/dts/qcom/ipq5018-mp03.5-c1.dts >> new file mode 100644 >> index 000000000000..51ddd7367ac6 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/ipq5018-mp03.5-c1.dts >> @@ -0,0 +1,64 @@ >> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause >> +/* >> + * IPQ5018 CP01 board device tree source >> + * >> + * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include "ipq5018.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. IPQ5018/AP-MP03.5-C1"; >> + compatible = "qcom,ipq5018-mp03.5-c1", "qcom,ipq5018"; >> + >> + aliases { >> + serial0 = &blsp1_uart1; >> + }; >> + >> + chosen { >> + bootargs = "console=ttyMSM0,115200,n8 rw init=/init swiotlb=1 coherent_pool=2M"; > > Not a common DT property. Drop. > Sure, i will drop it. >> + stdout-path = "serial0:115200n8"; >> + }; >> +}; >> + >> +&tlmm { >> + blsp0_uart_pins: uart_pins { > > Does not look like you tested the DTS against bindings. Please run `make > dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst > for instructions). > > I'll stop the review. Please first run tests. > > I will verify DTS against bindings. Thanks & Regards, Manikanta. > > Best regards, > Krzysztof >