From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Raihan Ahamed <raihan1999ahamed@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Kees Cook <kees@kernel.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G . Piccoli" <gpiccoli@igalia.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree
Date: Mon, 3 Nov 2025 12:25:24 +0100 [thread overview]
Message-ID: <93c4a167-805b-47f0-8e4b-76b1aeabb87e@kernel.org> (raw)
In-Reply-To: <e516564b-5e43-4628-836c-ff227a68d20e@oss.qualcomm.com>
On 03/11/2025 12:23, Konrad Dybcio wrote:
>> +
>> + one-key-low-power {
>> + label = "onekeylowpower";
>> + gpios = <&tlmm 86 GPIO_ACTIVE_LOW>;
>> + linux,code = <ABS_HAT1Y>;
>> + debounce-interval = <15>;
>> + };
>> +
>> + homepage {
>> + label = "homepage";
>> + gpios = <&tlmm 132 GPIO_ACTIVE_LOW>;
>> + linux,code = <KEY_HOMEPAGE>;
>> + debounce-interval = <15>;
>> + gpio-key,wakeup;
>> + };
>
> Please sort these nodes without an address by their name> + };
>> +
These will also fail tests :/
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-03 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 13:51 [PATCH v4 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Raihan Ahamed
2025-10-31 13:51 ` [PATCH v4 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree Raihan Ahamed
2025-11-03 11:23 ` Konrad Dybcio
2025-11-03 11:25 ` Krzysztof Kozlowski [this message]
2025-11-03 18:54 ` David Heidelberg
2025-11-02 16:14 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Add Lenovo P2 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c4a167-805b-47f0-8e4b-76b1aeabb87e@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raihan1999ahamed@gmail.com \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox