From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Swati Agarwal <swati.agarwal@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK
Date: Fri, 6 Feb 2026 13:24:44 +0100 [thread overview]
Message-ID: <93c81950-e679-4c2f-b0f7-c94be471a1df@oss.qualcomm.com> (raw)
In-Reply-To: <s2z4z2evasqi23n2agroelphvmx5y24sc5nv7t57iib2tqsaen@cvricqqpulh7>
On 2/6/26 1:12 PM, Dmitry Baryshkov wrote:
> On Fri, Feb 06, 2026 at 04:16:41PM +0530, Swati Agarwal wrote:
>> Enable PCA9538 expander3 as interrupt controller on Lemans EVK and
>> configures the corresponding TLMM pins via pinctrl to operate as GPIO
>> inputs with internal pull-ups.
>>
>> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/lemans-evk.dts | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> index a549f7fe53a1..473cc2a81670 100644
>> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
>> @@ -649,6 +649,12 @@ expander3: gpio@3b {
>> reg = <0x3b>;
>> #gpio-cells = <2>;
>> gpio-controller;
>> + #interrupt-cells = <2>;
>> + interrupt-controller;
>> + interrupt-parent = <&tlmm>;
>> + interrupts = <39 IRQ_TYPE_LEVEL_LOW>;
>
> interrupts-extended, please.
I think interrupt-parent makes sense for a child that's also an
interrupt provider, IDK if interrupt-extended maintains the
topology
Konrad
next prev parent reply other threads:[~2026-02-06 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 10:46 [PATCH 0/2] Enable tertiary USB controller in OTG mode Swati Agarwal
2026-02-06 10:46 ` [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK Swati Agarwal
2026-02-06 11:05 ` Konrad Dybcio
2026-02-06 12:12 ` Dmitry Baryshkov
2026-02-06 12:24 ` Konrad Dybcio [this message]
2026-02-06 10:46 ` [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller Swati Agarwal
2026-02-06 10:51 ` Krzysztof Kozlowski
2026-02-06 11:07 ` Konrad Dybcio
2026-02-06 12:14 ` Dmitry Baryshkov
2026-02-10 14:59 ` Swati Agarwal
2026-02-10 21:08 ` Dmitry Baryshkov
2026-02-11 0:23 ` Krishna Kurapati PSSNV
2026-02-11 1:47 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c81950-e679-4c2f-b0f7-c94be471a1df@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=swati.agarwal@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox