From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04DE4EB23 for ; Wed, 20 Mar 2024 16:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710950506; cv=none; b=h1MXHLU96bMVP/2B1AIzGF0e5iJ/Mh1HOF/2zqeQqqysdG1ttVxXUmMTv+8NCdb5s4pavZ/hRiyoUQzFTvHSjDud2Jc125mTiHlEvpHModvMQAycm7cfqStfjiZtz4FTWFnd+4T9oKaBCFCOvTIjcPaJShhODNn5gmCisoLfYSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710950506; c=relaxed/simple; bh=kJOH+rnAS2hEXejfUJZwazxTlSB8DY7It82kT/meYn8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KSp03qq3b7qbWFLkG48GS4DK3P7u68DM21BKcUc180wq3+UiqkuPcbTGDxyu8bvxr56oTO1la7eLL0OW1x7df3B1/aQNaIJJskbGMFEiOWnvwPo6I1lHhl96SChqODvA3u8N9w547ZwR65fQFHFLcpaoPCMnTzTDBJuYUPZnDxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zXVPuvRs; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zXVPuvRs" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4146a1b6faaso10787035e9.1 for ; Wed, 20 Mar 2024 09:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710950503; x=1711555303; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kL96kx3LN/9lm4lbLyIo1jNh4JW+F+59O3JF2oZwblI=; b=zXVPuvRs+uJ0obHjQjKp+UmikjjlQfiX3SSIrw2+PtFnxYp8pLjxy6Axv4OQcwsZP7 zfBxqAFSQVfHfqMuB1PnWGhf0sGExhi7DTfff2KMJumzQcKfdYI29u08uaODET1zNUJW XNynpWwpGwfar+sgccAMpPE6LdWE4hxFtl9EPUy4iREkHml6OcDfn2vGWVcVOFKhLWmt jm3BESgVJB0Fdm4KwT88CpPrzxkRurtIpI7xgLJm5bfg8w5wYhN3Tvd04lUTfzu8ehGm ZdpQBiZccqXv/pMdWS1dzPd+uI4aekwQ+KSXRiKywcDurPosN4OFthxMJL3sRmhLmxij YIKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710950503; x=1711555303; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kL96kx3LN/9lm4lbLyIo1jNh4JW+F+59O3JF2oZwblI=; b=QAZ0VhVxZEjlinYf3Os8gzTHjVypPFnvltt0ZwA6Buk0xN4t2sHzfkE1YTpJ2bwmNg rwHK4P6+WGjc6mDV2GjTvk31jv0HmZanbmkndr6/ntblPiUssm0NIKVivg6x1xBPkQFk A514IXSs0fDp1Xo6ZQfCtxqcyXEkWSWNOXYMJQp0Vy73cvRFkVzfeIQJ+UG7O3GpWbXU 3pkqpFTj02pLfDltc9wJvjdsXc4qKQdLiIcAVjkJ6NmTPQpu4c6HKuE7a187L9cv0JZY Cfpl0fRbA4zzIWw1J93+J0wBiyFXwWd7Dr7o2K+fzF5fvaQPkT7w3gQJeiQweUyENK/1 PY2A== X-Forwarded-Encrypted: i=1; AJvYcCVjBaxs0Ws/b9vQDqBFEg89s44cYC8LXIl7fsKRB04YoiiqMNftaMiq0E36K+zwmYKEZJBtl/jSXU+OGfcyE61KAMcHRxzdgzj5rKgpPw== X-Gm-Message-State: AOJu0YxbePAXQGXt0F6KtwJLfzH6jn4iuF6e04dK8P26Ie75wTvIgckW /aXQnO6dZBMHMZHWieb5/AP3NjdMifXveY9dNz2ykTnIhwDdK0SkQNvkHxFEa/k= X-Google-Smtp-Source: AGHT+IFIN6YIRXMa/mq1RLwjoKatqeyjBY5gl4ZOfUmSTIK1vlAArNKVYBMmbIRFvVAbqPe8dmgSPg== X-Received: by 2002:a5d:560e:0:b0:33e:bfd0:335c with SMTP id l14-20020a5d560e000000b0033ebfd0335cmr12054591wrv.51.1710950503210; Wed, 20 Mar 2024 09:01:43 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id dd15-20020a0560001e8f00b0033ce727e728sm14983529wrb.94.2024.03.20.09.01.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Mar 2024 09:01:42 -0700 (PDT) Message-ID: <944ff951-53dc-40f6-a7b0-5ecfc2cd4771@linaro.org> Date: Wed, 20 Mar 2024 16:01:41 +0000 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/8] media: qcom: camss: Add sm8550 support Content-Language: en-US To: Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, quic_yon@quicinc.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20240320141136.26827-1-quic_depengs@quicinc.com> <20240320141136.26827-9-quic_depengs@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <20240320141136.26827-9-quic_depengs@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/03/2024 14:11, Depeng Shao wrote: > Add in functional logic throughout the code to support the SM8550. > > Signed-off-by: Depeng Shao > --- > .../media/platform/qcom/camss/camss-csid.c | 19 +++++++++++++++++++ > .../media/platform/qcom/camss/camss-csiphy.c | 1 + > drivers/media/platform/qcom/camss/camss-vfe.c | 7 +++++++ > .../media/platform/qcom/camss/camss-video.c | 1 + > 4 files changed, 28 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c > index eb27d69e89a1..e9203dc15798 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.c > +++ b/drivers/media/platform/qcom/camss/camss-csid.c > @@ -590,6 +590,25 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid, > csid->base = camss->vfe[id].base + VFE_480_LITE_CSID_OFFSET; > else > csid->base = camss->vfe[id].base + VFE_480_CSID_OFFSET; > + } else if (camss->res->version == CAMSS_8550) { > + /* for titan 780, CSID lite registers are inside the VFE lite region, > + * between the VFE "top" and "bus" registers. this requires > + * VFE to be initialized before CSID > + */ > + if (id >= 2) > + csid->base = camss->vfe[id].base; Hard-coded magic numbers are definitely out. If you need to differentiate - please include something in the struct resources so that the flag is always available and we don't have to start doing funky magic index/magic number gymnastics. > + else { > + csid->base = > + devm_platform_ioremap_resource_byname(pdev, res->reg[0]); > + if (id != 0) > + csid->top_base = camss->csid[0].top_base; > + else > + csid->top_base = > + devm_platform_ioremap_resource_byname(pdev, res->reg[1]); > + } What is the point of hooking the TOP base just to clear our the status registers ? We take no meaningful action in the ISR that I can see. > + > + if (IS_ERR(csid->base)) > + return PTR_ERR(csid->base); > } else { > csid->base = devm_platform_ioremap_resource_byname(pdev, res->reg[0]); > if (IS_ERR(csid->base)) > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c > index 45b3a8e5dea4..f35af0dd2147 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c > @@ -579,6 +579,7 @@ int msm_csiphy_subdev_init(struct camss *camss, > case CAMSS_845: > case CAMSS_8250: > case CAMSS_8280XP: > + case CAMSS_8550: > csiphy->formats = csiphy_formats_sdm845; > csiphy->nformats = ARRAY_SIZE(csiphy_formats_sdm845); > break; > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index d875237cf244..ff115c5521c6 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -226,6 +226,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code, > case CAMSS_845: > case CAMSS_8250: > case CAMSS_8280XP: > + case CAMSS_8550: > switch (sink_code) { > case MEDIA_BUS_FMT_YUYV8_1X16: > { > @@ -296,6 +297,10 @@ int vfe_reset(struct vfe_device *vfe) > > reinit_completion(&vfe->reset_complete); > > + // The reset has been moved to csid in 8550 Please run checkpatch.pl on your code before submission C++ are not allowed. --- bod