From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>
Cc: hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: pci_generic: Increase num of elements in hw event ring
Date: Wed, 10 Feb 2021 13:38:43 -0700 [thread overview]
Message-ID: <95e7164b-9829-dd16-f485-4d24c25ea2c0@codeaurora.org> (raw)
In-Reply-To: <20210205123400.GD3221@thinkpad>
On 2/5/2021 5:34 AM, Manivannan Sadhasivam wrote:
> On Fri, Feb 05, 2021 at 09:36:35AM +0100, Loic Poulain wrote:
>> We met some sporadic modem crashes during high throughput testing, this
>> has been root caused to a lack of elements in the event ring. Indeed,
>> the modem is simply crashing when event ring becomes empty.
>>
>> It appears that the total number event ring elements is too low given
>> the performances of the modem (IPA hardware accelerator). This change
>> increases the number of elements in the hardware event ring to 2048,
>> which is aligned with what is defined in downstream version:
>> https://source.codeaurora.org/quic/la/kernel/msm-4.14/tree/arch/arm64/boot/dts/qcom/sm8150-mhi.dtsi?h=msm-4.14#n482
>>
>> With this change, modem coes not crash anymore.
>>
>> Note: An event ring element is 16-Byte, so the total memory usage of
>> a hardware event ring is now 32KB.
>>
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>
> Applied to mhi-next!
>
> Thanks,
> Mani
Probably too late, but there is a typo in the commit text. "modem coes
not crash" should be "modem does not crash".
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-02-10 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 8:36 [PATCH] bus: mhi: pci_generic: Increase num of elements in hw event ring Loic Poulain
2021-02-05 12:02 ` Manivannan Sadhasivam
2021-02-05 12:34 ` Manivannan Sadhasivam
2021-02-10 20:38 ` Jeffrey Hugo [this message]
2021-03-01 19:59 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95e7164b-9829-dd16-f485-4d24c25ea2c0@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox